[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    [Kde-pim] Review Request: Output error message when saving an
From:       "George  Metaxas" <gmetal31 () gmail ! com>
Date:       2010-12-12 16:43:22
Message-ID: 20101212164322.3439.77242 () vidsolbach ! de
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6104/
-----------------------------------------------------------

Review request for KDE PIM.


Summary
-------

As discussed in Bug 127981, when one attempts to save an attachment to a disk which \
has some space available, but not enough to fit the attachment, KMail will not output \
an error message informing the user about this. Instead, the attachment will be \
partially saved and the user will be oblivious to what really happened. This patch \
will show an error message to the user and will also remove the partially written \
file. KMail does indeed correctly inform the user if the disk has no space left, but \
it leaves behind a zero-sized file. This patch also removes this unnecessary file.


This addresses bug 127981.
    https://bugs.kde.org/show_bug.cgi?id=127981


Diffs
-----

  /trunk/KDE/kdepim/messageviewer/util.cpp 1205704 

Diff: http://svn.reviewboard.kde.org/r/6104/diff


Testing
-------

Tested saving an attachment with:
- No space left
- Some space left, but not enough to fit the attachment
- Enough space to fit the attachment


Thanks,

George

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]