From kde-pim  Sun Dec 12 10:31:21 2010
From: "Andras Mantia" <amantia () kde ! org>
Date: Sun, 12 Dec 2010 10:31:21 +0000
To: kde-pim
Subject: [Kde-pim] Re: Review Request: Support recursive collection
Message-Id: <20101212103121.27325.35824 () vidsolbach ! de>
X-MARC-Message: https://marc.info/?l=kde-pim&m=129214992111456



> On 2010-12-11 21:43:18, Ingo Klöcker wrote:
> > I object against changing the action bound to F5. F5 should always only reload/refresh the current object. This is how F5 works in all applications I know. I suggest using Ctrl+F5 for recursive sync. This would be in line with Konqueror's (normal) Reload (F5) vs. Force Reload (Ctrl+F5).
> > 
> > Note: I didn't have a look at the actual patch.

Seems I remembered wrongly, and KMail1 doesn't sync the folders recursively. In that case I withdraw the F5 assignment to be the default, but would like to change that if sync is called on the toplevel collection, than it is a sync collection (or recursive sync), and not a non-recursive sync of the toplevel collection. This is in line of what happens in KMail1.

The question is: what to do with the recursive sync standard action then, as I will need a new string to make it clear what it does. Does it make sense to request the exemption from the string freeze, or can we put this as it is now with a note to change the string in 4.7? I'd like to have the possibility to do recursive sync if needed.


- Andras


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6083/#review9204
-----------------------------------------------------------


On 2010-12-10 17:41:21, Andras Mantia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6083/
> -----------------------------------------------------------
> 
> (Updated 2010-12-10 17:41:21)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> As a user I'd expect that syncing a kmail folder syncronizes the folder and its subfolders. Might be useful in other cases as well. This patch implements this in resourcebase and agentmanager and adds a new action to the standard actions. F5 is reassigned to this new action. The user visible name right now is the same because:
> 1) i18n freeze
> 2) I believe this should be the standard behavior of a sync, so either they should be merged (the old action does recursive sync) or that one renamed when it is allowed. 
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepimlibs/CMakeLists.txt 1205259 
>   trunk/KDE/kdepimlibs/akonadi/agentmanager.h 1205259 
>   trunk/KDE/kdepimlibs/akonadi/agentmanager.cpp 1205259 
>   trunk/KDE/kdepimlibs/akonadi/kmime/standardmailactionmanager.cpp 1205259 
>   trunk/KDE/kdepimlibs/akonadi/resourcebase.h 1205259 
>   trunk/KDE/kdepimlibs/akonadi/resourcebase.cpp 1205259 
>   trunk/KDE/kdepimlibs/akonadi/standardactionmanager.h 1205259 
>   trunk/KDE/kdepimlibs/akonadi/standardactionmanager.cpp 1205259 
> 
> Diff: http://svn.reviewboard.kde.org/r/6083/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andras
> 
>

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/