From kde-pim  Sat Dec 11 21:43:06 2010
From: =?utf-8?q?Ingo_Kl=C3=B6cker?= <kloecker () kde ! org>
Date: Sat, 11 Dec 2010 21:43:06 +0000
To: kde-pim
Subject: [Kde-pim] Re: Review Request: Support recursive collection
Message-Id: <20101211214306.8031.45173 () vidsolbach ! de>
X-MARC-Message: https://marc.info/?l=kde-pim&m=129210383314613


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6083/#review9204
-----------------------------------------------------------


I object against changing the action bound to F5. F5 should always only reload/refresh the current object. This is how F5 works in all applications I know. I suggest using Ctrl+F5 for recursive sync. This would be in line with Konqueror's (normal) Reload (F5) vs. Force Reload (Ctrl+F5).

Note: I didn't have a look at the actual patch.

- Ingo


On 2010-12-10 17:41:21, Andras Mantia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6083/
> -----------------------------------------------------------
> 
> (Updated 2010-12-10 17:41:21)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> As a user I'd expect that syncing a kmail folder syncronizes the folder and its subfolders. Might be useful in other cases as well. This patch implements this in resourcebase and agentmanager and adds a new action to the standard actions. F5 is reassigned to this new action. The user visible name right now is the same because:
> 1) i18n freeze
> 2) I believe this should be the standard behavior of a sync, so either they should be merged (the old action does recursive sync) or that one renamed when it is allowed. 
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepimlibs/CMakeLists.txt 1205259 
>   trunk/KDE/kdepimlibs/akonadi/agentmanager.h 1205259 
>   trunk/KDE/kdepimlibs/akonadi/agentmanager.cpp 1205259 
>   trunk/KDE/kdepimlibs/akonadi/kmime/standardmailactionmanager.cpp 1205259 
>   trunk/KDE/kdepimlibs/akonadi/resourcebase.h 1205259 
>   trunk/KDE/kdepimlibs/akonadi/resourcebase.cpp 1205259 
>   trunk/KDE/kdepimlibs/akonadi/standardactionmanager.h 1205259 
>   trunk/KDE/kdepimlibs/akonadi/standardactionmanager.cpp 1205259 
> 
> Diff: http://svn.reviewboard.kde.org/r/6083/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andras
> 
>

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/