[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    [Kde-pim] Review Request: Add support for disabled alarms in
From:       "Sergio Martins" <iamsergio () gmail ! com>
Date:       2010-09-29 15:14:59
Message-ID: 20100929151459.17544.8765 () vidsolbach ! de
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5475/
-----------------------------------------------------------

Review request for KDE PIM, Allen Winter and Alvaro Manera.


Summary
-------

Incidence editors have a button called "Disable Alarm", which calls \
alarm->setEnabled( false ), but when the alarm is serialized to file, this \
information is lost. When the alarm is loaded again, it will be enabled.

Kolab's xml format has a property for supporting disabled alarms, but, because it's \
serialized to ical by akonadi, this info disappears.

This patch adds an KCalCore::Alarm custom property indicating if the alarm is enabled \
or not.


Diffs
-----

  trunk/KDE/kdepimlibs/kcalcore/icalformat_p.cpp 1176540 

Diff: http://svn.reviewboard.kde.org/r/5475/diff


Testing
-------

Tested the editors. Unit tests are running.


Thanks,

Sergio

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]