[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request: KOrganizer 4.5 - Use more efficient
From:       "John Layt" <johnlayt () googlemail ! com>
Date:       2010-09-16 20:32:43
Message-ID: 20100916203243.25777.65837 () vidsolbach ! de
[Download RAW message or body]



> On 2010-09-15 23:43:00, Sergio Martins wrote:
> > Looks OK.
> > 
> > Thanks!

Committed to 4.5 in r1176162.  Do you want this in 4.4 as well?


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5343/#review7628
-----------------------------------------------------------


On 2010-09-15 14:45:58, John Layt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5343/
> -----------------------------------------------------------
> 
> (Updated 2010-09-15 14:45:58)
> 
> 
> Review request for KDE PIM and Sergio Martins.
> 
> 
> Summary
> -------
> 
> Use the KHolidays date range call rather than each date individually as this is \
> more efficient.  See bug 251127. 
> The ActionManager change is also suitable for trunk, but the other changes are just \
> coded to make the minimal changes required and should be done differently in trunk. \
>  
> These could be backported to 4.4 conditional on KDEPIMLIBS_VERSION >= \
> KDE_MAKE_VERSION(4,5,0).  Thoughts? 
> In KODayMatrix I also use the weekDayOfPray() value from the global locale which \
> the user is able to set, rather than the calendar one which is deprecated.  I'll \
> forwardport to trunk. 
> 
> This addresses bug 251127.
> https://bugs.kde.org/show_bug.cgi?id=251127
> 
> 
> Diffs
> -----
> 
> /branches/KDE/4.5/kdepim/korganizer/actionmanager.cpp 1175189 
> /branches/KDE/4.5/kdepim/korganizer/kodaymatrix.cpp 1175189 
> /branches/KDE/4.5/kdepim/korganizer/views/agendaview/koagendaview.cpp 1175189 
> /branches/KDE/4.5/kdepim/korganizer/views/monthview/monthview.cpp 1175189 
> 
> Diff: http://svn.reviewboard.kde.org/r/5343/diff
> 
> 
> Testing
> -------
> 
> Ran KOrg, holidays still show up in date picker, month view, agenda view and html \
> export.  Feels slightly snappier, but no benchmarks :-) 
> 
> Thanks,
> 
> John
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]