[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-pim
Subject: Re: [Kde-pim] Review Request: Allow disabling Akregator's tray icon
From: "Simon Ruggier" <simon80 () gmail ! com>
Date: 2010-06-15 6:58:14
Message-ID: 20100615065814.28258.96680 () localhost
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4044/
-----------------------------------------------------------
(Updated 2010-06-15 06:58:14.061486)
Review request for KDE PIM.
Changes
-------
Hi, my apologies for screwing up, but I just noticed that the patch I submitted is \
missing a signal connection in the affected UI file. This happened because the patch \
I initially wrote for my old version of Akregator failed to apply on trunk, so the \
patch I submitted was actually reimplemented from scratch on the UI file in trunk. I \
mentioned this situation in the bug, but not here. The patch I'm submitting now has \
actually been tested to work as intended, and by viewing a comparison of the diffs, \
the missing connection should be clear.
Summary (updated)
-------
Allow disabling Akregator's tray icon unread article count
The unread article count in Akregator's tray icon is useful, but can be
very distracting. A checkbox is provided to offer the choice of
disabling the unread article count, instead showing the default icon at
all times.
This addresses bug 234385.
https://bugs.kde.org/show_bug.cgi?id=234385
Diffs (updated)
-----
/trunk/KDE/kdepim/akregator/configuration/settings_general.ui 1106345
/trunk/KDE/kdepim/akregator/interfaces/akregator.kcfg 1106345
/trunk/KDE/kdepim/akregator/src/trayicon.cpp 1106345
Diff: http://reviewboard.kde.org/r/4044/diff
Testing
-------
Built, ran, used for weeks with the count disabled, and tried switching the setting \
on and off while there are unread items.
Thanks,
Simon
_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]