From kde-pim Fri Jun 11 10:56:47 2010 From: "Thomas McGuire" Date: Fri, 11 Jun 2010 10:56:47 +0000 To: kde-pim Subject: Re: [Kde-pim] Review Request: Add text direction switch buttons to Message-Id: <20100611105647.30535.78843 () localhost> X-MARC-Message: https://marc.info/?l=kde-pim&m=127625384522967 ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4187/#review6090 ----------------------------------------------------------- Looks good! I didn't actually try it out yet, but the code looks fine. On the KMail side, Please wait until trunk is out of feature-freeze and then commit. /trunk/KDE/kdelibs/kdeui/widgets/krichtextedit.h missing "@since 4.6" in the comment - Thomas On 2010-06-01 22:16:02, Mohammad Ebrahim Mohammadi Panah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/4187/ > ----------------------------------------------------------- > > (Updated 2010-06-01 22:16:02) > > > Review request for KDE PIM and Thomas McGuire. > > > Summary > ------- > > Add text direction switch buttons to KRichTextEdit, and use that in KMail > > > This addresses bug 181311. > https://bugs.kde.org/show_bug.cgi?id=181311 > > > Diffs > ----- > > /trunk/KDE/kdepim/kmail/kmcomposewin.cpp 1132977 > /trunk/KDE/kdepim/kmail/kmcomposerui.rc 1132977 > /trunk/KDE/kdelibs/kdeui/widgets/krichtextwidget.h 1132977 > /trunk/KDE/kdelibs/kdeui/widgets/krichtextwidget.cpp 1132977 > /trunk/KDE/kdelibs/kdeui/widgets/krichtextedit.h 1132977 > /trunk/KDE/kdelibs/kdeui/widgets/krichtextedit.cpp 1132977 > > Diff: http://reviewboard.kde.org/r/4187/diff > > > Testing > ------- > > > Thanks, > > Mohammad Ebrahim > > _______________________________________________ KDE PIM mailing list kde-pim@kde.org https://mail.kde.org/mailman/listinfo/kde-pim KDE PIM home page at http://pim.kde.org/