[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request: KMail Composer: Add dragged files as
From:       Ingo_Klöcker <kloecker () kde ! org>
Date:       2010-04-21 21:31:47
Message-ID: 20100421213147.13433.47134 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3720/#review5153
-----------------------------------------------------------


The difference between KMail (resp. KDE in general) and Thunderbird or Windows is \
that KMail (resp. KDE) can do things neither of the other two can do. Thanks to KIO, \
KMail can attach files referenced by any URL. Now the thing is that sometimes you \
might not want to attach the actual file (e.g. a DVD image) linked to by an http-URL, \
but instead you just want to paste the URL into the message.

Of course, the question is whether we should allow pasting a URL via drag and drop. \
Maybe we shouldn't. Or maybe we should simply make the mechanism smarter and only ask \
for non-local URLs whether the file(s) should be downloaded and attached or whether \
just the link(s) should be pasted.

So, my proposal is:
- Only ask the question for non-local URLs.
- Improve the wording of the question so that it becomes clearer what the \
alternatives are.

- Ingo


On 2010-04-21 16:12:39, Sascha Peilicke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3720/
> -----------------------------------------------------------
> 
> (Updated 2010-04-21 16:12:39)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Currently, when dropping one or multiple files onto the KMail composer window, a \
> popup dialog asks to either add the files inline or as attachments. IMHO adding \
> inline makes little sense and other mail clients (Thunderbird, Windows Live Mail) \
> automatically add dragged files as attachments.  
> Thus this patch removes that dialog and aligns the composer's drag-n-drop behavior \
> to the competition. 
> 
> Diffs
> -----
> 
> trunk/KDE/kdepim/kmail/kmcomposereditor.cpp 1117232 
> 
> Diff: http://reviewboard.kde.org/r/3720/diff
> 
> 
> Testing
> -------
> 
> works on trunk r1117232
> 
> 
> Thanks,
> 
> Sascha
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]