[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request: Akonadi self test for PostgreSQL
From:       "Brian DeRocher" <brian () derocher ! org>
Date:       2010-03-23 14:20:38
Message-ID: 20100323142038.24762.81724 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3339/
-----------------------------------------------------------

(Updated 2010-03-23 14:20:38.015693)


Review request for KDE PIM.


Changes
-------

Use !username.isEmpty() instead of username != notNeeded, as per tokoe.


Summary
-------

The Akonadi self test connects to the PostgreSQL database as akonadi/akonadi, if the \
config file akonadiserverrc does not specify a username and password.  When the \
database was initialized (dbconfigpostgresql.cpp) a username a password were not \
written to the config file.  The connection is made as the current user.  In the \
database, the only role that exists is the local user.

This change will have the self test use a username and password if found in the \
config file.  Otherwise they are not used for the connection.


Diffs (updated)
-----

  /trunk/KDE/kdepimlibs/akonadi/selftestdialog.cpp 1105514 

Diff: http://reviewboard.kde.org/r/3339/diff


Testing
-------


I ran kcmshell4 kcm_akonadi.  Before the patch there was an X.  The detail message \
said 

FATAL:  role "akonadi" does not exist
QPSQL: Unable to connect

With the patch the detail message is

The PostgreSQL server was found and connection is working.

I have not run a regression test, but would be glad to if someone shows me how.


Screenshots
-----------

PostgreSQL found
  http://reviewboard.kde.org/r/3339/s/339/


Thanks,

Brian

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]