[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-pim
Subject: Re: [Kde-pim] Review Request: Krazy fixes for kdepim/kjots,
From: "Stephen Kelly" <steveire () gmail ! com>
Date: 2010-03-23 11:39:12
Message-ID: 20100323113912.16879.32016 () localhost
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3353/#review4623
-----------------------------------------------------------
Ship it!
Looks good. Please commit.
- Stephen
On 2010-03-23 11:07:53, Lasse Liehu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3353/
> -----------------------------------------------------------
>
> (Updated 2010-03-23 11:07:53)
>
>
> Review request for KDE PIM.
>
>
> Summary
> -------
>
> This fixes those Krazy issues in category qclasses (for kdepim/kjots) that can be \
> fixed. Also it seemed m_widget in KJotsPart wasn't used at all so I removed it. It \
> seems component member is used instead.
>
> Diffs
> -----
>
> svn://anonsvn.kde.org/home/kde/trunk/KDE/kdepim/kjots/kjotsbrowser.h 1106497
> svn://anonsvn.kde.org/home/kde/trunk/KDE/kdepim/kjots/kjotsbrowser.cpp 1106497
> svn://anonsvn.kde.org/home/kde/trunk/KDE/kdepim/kjots/kjotspart.h 1106497
> svn://anonsvn.kde.org/home/kde/trunk/KDE/kdepim/kjots/kjotswidget.h 1106497
> svn://anonsvn.kde.org/home/kde/trunk/KDE/kdepim/kjots/kjotswidget.cpp 1106497
>
> Diff: http://reviewboard.kde.org/r/3353/diff
>
>
> Testing
> -------
>
> It compiles and doesn't give warnings. Also the application starts and I can type \
> something to a page. Pretty much nothing so to say.
>
> Thanks,
>
> Lasse
>
>
_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic