[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim]
From:       Ingo =?iso-8859-1?q?Kl=F6cker?= <kloecker () kde ! org>
Date:       2010-01-24 10:05:07
Message-ID: 201001241105.12514 () thufir ! ingo-kloecker ! de
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Saturday 23 January 2010, John Layt wrote:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2709/
> -----------------------------------------------------------
>
> Review request for KDE PIM.
>
>
> Summary
> -------
>
> This change implements phase 1 of the overhaul of KHolidays.  It
> cleans up the file structures, adds some new public api, and adds a
> new parser which supports non-Gregorian calendar systems.  The
> library still uses the old parser for now, but will be switched in
> the next phase.
>
> The holidays.h/.cpp files contained both the Holiday and
> HolidayRegion classes.  These needed to be split to prevent circular
> includes, however it is backwards-compatible as apps still only need
> to include holidays.h.  The following files were created using svn
> copy:
>
>     kholidays/holiday_p.h   // HolidayPrivate class
>     kholidays/holiday.h     // Holiday class
>     kholidays/holiday.cpp
>     kholidays/holidays.h    // Now only HolidayRegion class
>     kholidays/holidays.cpp
>
> (Perhaps also move HolidayRegion into holidayregion.h/.cpp with a
> placeholder holiday.h just including the other headers?

Yes, please. It's unnecessarily confusing and annoying if the name of a=20
header file does not match the class name.


Regards,
Ingo

["signature.asc" (application/pgp-signature)]

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

[prev in list] [next in list] [prev in thread] [next in thread]