[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request: Add config file only option to
From:       "Frank Osterfeld" <frank.osterfeld () gmail ! com>
Date:       2010-01-20 8:33:14
Message-ID: 20100120083314.29792.190 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2474/#review3756
-----------------------------------------------------------


Good idea in general,
some remarks:
* Please use the kcfg file/Settings object to store/access the config key
* No need for the member variable then
* listen to config changes via a slot (iirc Settings has a signal for that) to \
reapply the setting if it changed. That will become useful once their is UI (which \
can be done in trunk/akonadi-ports).

- Frank


On 2010-01-04 07:16:48, Michael Seiwert wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2474/
> -----------------------------------------------------------
> 
> (Updated 2010-01-04 07:16:48)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> This patch adds a config file only option to akregator to configure \
> enabling/disabling showing flash content in the article viewer. As you have to \
> manually set the config entry "Plugins Enabled" to "true" the default behavior \
> stays unchanged (flash plugins disabled). I'd like to add a visual config option to \
> the browser section in akgregator configuration dialog later as well.       
> 
> Diffs
> -----
> 
> /trunk/KDE/kdepim/akregator/src/articleviewer.h 1068826 
> /trunk/KDE/kdepim/akregator/src/articleviewer.cpp 1068826 
> 
> Diff: http://reviewboard.kde.org/r/2474/diff
> 
> 
> Testing
> -------
> 
> Enabling and disabling seems to work if manually configured via "Plugins Enabled" 
> 
> 
> Thanks,
> 
> Michael
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]