[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request: knode: side-by-side view
From:       "Matthew Woehlke" <mw_triad () users ! sourceforge ! net>
Date:       2010-01-11 17:52:39
Message-ID: 20100111175239.24631.70449 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2526/
-----------------------------------------------------------

(Updated 2010-01-11 17:52:39.145867)


Review request for KDE PIM.


Changes
-------

Add apidoc, fix i18n, remove unneeded slot call.


Summary
-------

One of the "must have" features preventing me from switching from Thunderbird is a \
side by side layout; that is, folder list, message list, and message view in three \
columns (message view under message list is a waste of space (on my/large screens \
anyway); both will have almost half the right side always empty space).

Fortunately, it is quite simple to change the splitter between message list and \
message view from vertical to horizontal, and not hard to then make that \
configurable. So that is what this patch does; adds a new menu \
View->Layout->{Classic,Side by Side} (plus code to save/load the setting).

There is a small bug fix as well (line 725/734) that fixes slotArtSortHeaders not \
being bound correctly (and thus that menu being non-functional) since I copied that \
code for the new menu and had to track down the bug to get the new menu to work.


Diffs (updated)
-----

  /trunk/KDE/kdepim/knode/knmainwidget.h 1073089 
  /trunk/KDE/kdepim/knode/knmainwidget.cpp 1073089 
  /trunk/KDE/kdepim/knode/knodeui.rc 1073089 

Diff: http://reviewboard.kde.org/r/2526/diff


Testing
-------


Thanks,

Matthew

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]