From kde-pim  Thu Jan 07 17:09:31 2010
From: Stefano Avallone <stavallo () unina ! it>
Date: Thu, 07 Jan 2010 17:09:31 +0000
To: kde-pim
Subject: Re: [Kde-pim] Review Request: Add support for multiple phone
Message-Id: <201001071809.33261.stavallo () unina ! it>
X-MARC-Message: https://marc.info/?l=kde-pim&m=126289037022703

Ok, I see. I will be back with the unit tests ;-)

Regards,
Stefano


On Thursday 07 January 2010 16:44:15 Adenilson Cavalcanti wrote:
> Stefano
> 
> I ask you to only issue the merge request *after* the unit tests are
> ready. I went to great effort to write libgcal following TDD (Test
> Driven Development) and its payback is more stable and easier to
> maintain code.
> 
> Besides, if we left it to later, the chances are that it will be forgotten.
> ;-)
> 
> 
> Regards
> 
> 
> Adenilson
> 
> On Wed, Jan 6, 2010 at 8:53 PM, Stefano Avallone <stavallo@unina.it> wrote:
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > http://reviewboard.kde.org/r/2502/
> > -----------------------------------------------------------
> >
> > (Updated 2010-01-07 00:53:06.105937)
> >
> >
> > Review request for KDE PIM.
> >
> >
> > Changes
> > -------
> >
> > Adenilson,
> >
> > please find a new version of the patch. I think I have addressed all the
> > comments from you and Kevin. I have not tried the pahole tool yet
> > (hopefully I will do so soon). I have also pushed my patch against
> > libgcal to my cloned repository on gitorious. Shall I issue a merge
> > request? Once we agree on a final version for this patch, I will also try
> > to make some unit tests.
> >
> >
> > Summary
> > -------
> >
> > Currently, the akonadi googledata agent (and libgcal) does not support
> > multiple phone numbers and email addresses per contact. This patch (along
> > with a patch against libgcal, posted to the kde-extra-gear and kde-pim
> > mailing lists) adds such support. An attempt is made to match Google
> > labels for phone number types (work, home, etc.) and the label used by
> > KAddressBook. Also, the group membership info associated with each 
Google
> > contact is stored as a custom propoerty in Akonadi, thus this information
> > is not lost when the contact is updated within KAddressBook.
> >
> >
> > Diffs (updated)
> > -----
> >
> >  /trunk/extragear/pim/googledata/contacts/googledataresource.cpp 1066667
> >
> > Diff: http://reviewboard.kde.org/r/2502/diff
> >
> >
> > Testing
> > -------
> >
> > I have done some tests with my Google account and it works. Also, a
> > Chakra user reported it works for him, too.
> >
> >
> > Thanks,
> >
> > Stefano
> 
_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/