[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request: Add support for multiple phone
From:       "Stefano Avallone" <stavallo () unina ! it>
Date:       2010-01-05 23:29:33
Message-ID: 20100105232933.12084.11446 () localhost
[Download RAW message or body]



> On 2010-01-05 10:35:43, Kevin Krammer wrote:
> > 

Thanks for your comments again, which are being addressed in the next revision.


> On 2010-01-05 10:35:43, Kevin Krammer wrote:
> > /trunk/extragear/pim/googledata/contacts/googledataresource.cpp, line 128
> > <http://reviewboard.kde.org/r/2502/diff/1/?file=16517#file16517line128>
> > 
> > Not sure what Adenilson's coding style is so this is up to him, but I personally \
> > find it easier to read when conditions are real booleans instead of interpreting \
> > certain values of integers as boolean values, i.e. strcmp( label, "home" ) == 0

On line 361, the notation !strcmp has been used (by Adenilson). Shall I leave !strcmp \
everywhere?


- Stefano


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2502/#review3580
-----------------------------------------------------------


On 2010-01-04 23:58:39, Stefano Avallone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2502/
> -----------------------------------------------------------
> 
> (Updated 2010-01-04 23:58:39)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Currently, the akonadi googledata agent (and libgcal) does not support multiple \
> phone numbers and email addresses per contact. This patch (along with a patch \
> against libgcal, posted to the kde-extra-gear and kde-pim mailing lists) adds such \
> support. An attempt is made to match Google labels for phone number types (work, \
> home, etc.) and the label used by KAddressBook. Also, the group membership info \
> associated with each Google contact is stored as a custom propoerty in Akonadi, \
> thus this information is not lost when the contact is updated within KAddressBook. 
> 
> Diffs
> -----
> 
> /trunk/extragear/pim/googledata/contacts/googledataresource.cpp 1066667 
> 
> Diff: http://reviewboard.kde.org/r/2502/diff
> 
> 
> Testing
> -------
> 
> I have done some tests with my Google account and it works. Also, a Chakra user \
> reported it works for him, too. 
> 
> Thanks,
> 
> Stefano
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]