[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request: Possible fix for KMail's
From:       "Thomas McGuire" <mcguire () kde ! org>
Date:       2009-12-19 14:00:52
Message-ID: 20091219140052.20206.19245 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2370/#review3456
-----------------------------------------------------------


Can you explain why this patch fixes a crash? How can the crashes be reproduced?

Honestly I'd rather not commit a patch without anybody knowing what it does. I'd like \
to fix the real defect, and not some symptoms of it.

- Thomas


On 2009-12-13 23:54:53, Allen Winter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2370/
> -----------------------------------------------------------
> 
> (Updated 2009-12-13 23:54:53)
> 
> 
> Review request for KDE PIM and Thomas McGuire.
> 
> 
> Summary
> -------
> 
> Here's a patch for KMReaderWin::setMsg() that fixes some crashes by exiting before \
> getting to updateReaderWin() in the aMsg == message() case. 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdepim/kmail/kmreaderwin.cpp 1062157 
> 
> Diff: http://reviewboard.kde.org/r/2370/diff
> 
> 
> Testing
> -------
> 
> I was encountering lots of crashes before the patch and haven't had any crashes \
> since.  Not a scientific test, admittedly. But that's why we have code review :) 
> 
> Thanks,
> 
> Allen
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]