[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-pim
Subject: Re: [Kde-pim] Review Request: Add support for X- parameters in ICal
From: "Kevin Krammer" <kevin.krammer () gmx ! at>
Date: 2009-11-10 11:32:39
Message-ID: 20091110113239.27711.165 () localhost
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2093/#review3000
-----------------------------------------------------------
/trunk/KDE/kdepimlibs/kcal/attendee.h
<http://reviewboard.kde.org/r/2093/#comment2449>
A const variant might be nice for code that gets a const Attendee& and just wants \
read access to the custom properties
/trunk/KDE/kdepimlibs/kcal/icalformat_p.cpp
<http://reviewboard.kde.org/r/2093/#comment2450>
should be a const QMap<QByteArray, QString> or using constBegin() constEnd() in \
the for loop to avoid detaching of implicitly shared data
see ICalFormatImpl::Private::writeCustomProperties in the same file
- Kevin
On 2009-11-09 19:30:31, Grégory Oestreicher wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2093/
> -----------------------------------------------------------
>
> (Updated 2009-11-09 19:30:31)
>
>
> Review request for KDE PIM.
>
>
> Summary
> -------
>
> This patch adds support to load and save X- parameters for ICal as defined in \
> RFC2445, §4.8.8.1. These parameters are not processed by KCal and should be loaded \
> and saved as-is, without further processing.
>
> Diffs
> -----
>
> /trunk/KDE/kdepimlibs/kcal/attendee.cpp 1046599
> /trunk/KDE/kdepimlibs/kcal/icalformat_p.cpp 1046599
> /trunk/KDE/kdepimlibs/kcal/attendee.h 1046599
>
> Diff: http://reviewboard.kde.org/r/2093/diff
>
>
> Testing
> -------
>
> Yes, with Egroupware using GroupDAV. The X-EGROUPWARE-UID parameter was preserved \
> when saving the entry.
>
> Thanks,
>
> Grégory
>
>
_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic