[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-pim
Subject: Re: [Kde-pim] Review Request: Add support for X- parameters in ICal
From: "Allen Winter" <winter () kde ! org>
Date: 2009-11-09 21:45:43
Message-ID: 20091109214543.12663.54690 () localhost
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2093/#review2993
-----------------------------------------------------------
Ship it!
much nicer. please make the few minor changes I noted and then feel free to commit it
/trunk/KDE/kdepimlibs/kcal/attendee.h
<http://reviewboard.kde.org/r/2093/#comment2443>
@since 4.4
/trunk/KDE/kdepimlibs/kcal/attendee.h
<http://reviewboard.kde.org/r/2093/#comment2444>
@since 4.4
/trunk/KDE/kdepimlibs/kcal/icalformat_p.cpp
<http://reviewboard.kde.org/r/2093/#comment2445>
move the else up 1 line with the closing if-brace
- Allen
On 2009-11-09 19:30:31, Grégory Oestreicher wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2093/
> -----------------------------------------------------------
>
> (Updated 2009-11-09 19:30:31)
>
>
> Review request for KDE PIM.
>
>
> Summary
> -------
>
> This patch adds support to load and save X- parameters for ICal as defined in \
> RFC2445, §4.8.8.1. These parameters are not processed by KCal and should be loaded \
> and saved as-is, without further processing.
>
> Diffs
> -----
>
> /trunk/KDE/kdepimlibs/kcal/attendee.cpp 1046599
> /trunk/KDE/kdepimlibs/kcal/icalformat_p.cpp 1046599
> /trunk/KDE/kdepimlibs/kcal/attendee.h 1046599
>
> Diff: http://reviewboard.kde.org/r/2093/diff
>
>
> Testing
> -------
>
> Yes, with Egroupware using GroupDAV. The X-EGROUPWARE-UID parameter was preserved \
> when saving the entry.
>
> Thanks,
>
> Grégory
>
>
_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic