[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request: adds kmail support for RFC2369,
From:       Ingo_Klöcker <kloecker () kde ! org>
Date:       2009-10-23 11:19:40
Message-ID: 20091023111940.19798.85880 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1768/#review2783
-----------------------------------------------------------


Just a few minor comments.

You can add the List-ID as title to the menu with addTitle( listId );


/trunk/KDE/kdepim/kmail/mailinglist-magic.cpp
<http://reviewboard.kde.org/r/1768/#comment2133>

    Storing the ArchivedAt address does not make sense since it is different for each \
mailing list message. Those config entries are just for general mailing list specific \
entries.



/trunk/KDE/kdepim/kmail/mailinglist-magic.cpp
<http://reviewboard.kde.org/r/1768/#comment2134>

    See above.



/trunk/KDE/kdepim/kmail/messageactions.cpp
<http://reviewboard.kde.org/r/1768/#comment2135>

    Remove one of the spaces before new. Add spaces after '(', after ',' and before \
')'. Please also check the rest of the patch.



/trunk/KDE/kdepim/kmail/messageactions.cpp
<http://reviewboard.kde.org/r/1768/#comment2136>

    Note that within SIGNAL() and SLOT() we do not use spaces after '(' or before \
')', so here it's okay that there are no spaces. You should probably still add a \
space between QAction and '*' in SLOT() (for symmetry with the signal in SIGNAL()).



/trunk/KDE/kdepim/kmail/messageactions.cpp
<http://reviewboard.kde.org/r/1768/#comment2137>

    const int start = ...



/trunk/KDE/kdepim/kmail/messageactions.cpp
<http://reviewboard.kde.org/r/1768/#comment2138>

    const int end = ...



/trunk/KDE/kdepim/kmail/messageactions.cpp
<http://reviewboard.kde.org/r/1768/#comment2139>

    Space after ','.



/trunk/KDE/kdepim/kmail/messageactions.cpp
<http://reviewboard.kde.org/r/1768/#comment2140>

    "Go to Archive of This Message"
    Hmm, doesn't sound too good. Maybe, "Open Archived Message" or "Open Message in \
List Archive".



/trunk/KDE/kdepim/kmail/messageactions.cpp
<http://reviewboard.kde.org/r/1768/#comment2141>

    "Subscribe to List"
    We use title capitalization for the text of actions.



/trunk/KDE/kdepim/kmail/messageactions.cpp
<http://reviewboard.kde.org/r/1768/#comment2142>

    Unsubscribe from List



/trunk/KDE/kdepim/kmail/messageactions.cpp
<http://reviewboard.kde.org/r/1768/#comment2143>

    Use kDebug() instead of kWarning(). Warnings are visible for users in release \
mode, but in this case a warning is not really necessary.



/trunk/KDE/kdepim/kmail/messageactions.cpp
<http://reviewboard.kde.org/r/1768/#comment2144>

    ... = url.protocol().lower()
    
    so that the comparison with "mailto" and "http" is case insensitive



/trunk/KDE/kdepim/kmail/messageactions.cpp
<http://reviewboard.kde.org/r/1768/#comment2145>

    if ( protocol == "mailto" ) {



/trunk/KDE/kdepim/kmail/messageactions.cpp
<http://reviewboard.kde.org/r/1768/#comment2146>

    Please re-add the i18nc(). Some translators might want to change the order of \
item and protocol (e.g. in RTL languages). Or they might want to replace the \
parentheses with something else.


- Ingo


On 2009-10-23 02:19:22, Daniel Black wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1768/
> -----------------------------------------------------------
> 
> (Updated 2009-10-23 02:19:22)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> This patch displays the List{-ID,post,subscriber,unsubscribe,archive,help,owner} \
> RFC2369, List-ID is RFC2919 and Archived-At (RFC5064) URLs of email header fields \
> on header context of kmail preview pane. 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdepim/kmail/kmmainwidget.h 1039203 
> /trunk/KDE/kdepim/kmail/kmmainwidget.cpp 1039203 
> /trunk/KDE/kdepim/kmail/mailinglist-magic.h 1039203 
> /trunk/KDE/kdepim/kmail/mailinglist-magic.cpp 1039203 
> /trunk/KDE/kdepim/kmail/messageactions.h 1039203 
> /trunk/KDE/kdepim/kmail/messageactions.cpp 1039203 
> 
> Diff: http://reviewboard.kde.org/r/1768/diff
> 
> 
> Testing
> -------
> 
> tested on kmail-1.12.1 (kde-4.3.1)
> 
> 
> Screenshots
> -----------
> 
> kmail context menu with mailing list info
> http://reviewboard.kde.org/r/1768/s/234/
> 
> 
> Thanks,
> 
> Daniel
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]