[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request: adds kmail support for RFC2369,
From:       "Daniel Black" <daniel.subs () internode ! on ! net>
Date:       2009-10-23 1:08:23
Message-ID: 20091023010823.4181.8493 () localhost
[Download RAW message or body]



> On 2009-10-22 16:28:43, Thomas McGuire wrote:
> > /trunk/KDE/kdepim/kmail/messageactions.cpp, line 182
> > <http://reviewboard.kde.org/r/1768/diff/4/?file=13176#file13176line182>
> > 
> > Mailing-List Information is too long IMHO, just use "Mailing List" (also without \
> > the hyphen, since that is what is used in the folder menu)
> 
> wrote:
> Mailing-List" was chosen for consistency with "Reply to Mailing-List". Shortening \
> is fine though Ingo is suggesting putting the List-id here too. Can submenu's have \
> header text? Either that or "Mailing-List - KDE PIM". I could drop it but sometimes \
> there is good information here as to what the specific list topic is.

1: "Mailing List" - count 4 (excluding warnings/debug)
$ grep -i Mailing\ List *.cpp | fgrep -v '//'
kmmainwidget.cpp:  mFolderMailingListPropertiesAction = new KAction(i18n("&Mailing \
                List Management..."), this);
mailinglist-magic.cpp:  if ( header.isNull() || header.left(13 ) != "mailing list"    \
                
mailinglist-magic.cpp:      kDebug()<<"Serious mailing list header parsing error !";  \
                
mailinglist-magic.cpp:    kDebug()<<"Mailing list ="<<header.mid( start, end - start \
                );                        
mailinglistpropertiesdialog.cpp:  QGroupBox *mlGroup = new QGroupBox( \
                i18n("Associated Mailing List" ), this );
mailinglistpropertiesdialog.cpp:  mHoldsMailingList = new QCheckBox( i18n("&Folder \
                holds a mailing list"), mlGroup );
mailinglistpropertiesdialog.cpp:  label = new QLabel( i18n("Mailing list \
                description:"), mlGroup );                  
mailinglistpropertiesdialog.cpp:  kDebug()<< "Detecting mailing list";                \
                
mailinglistpropertiesdialog.cpp:              i18n("KMail was unable to detect a \
                mailing list in this folder. "      
mailinglistpropertiesdialog.cpp:    kWarning()<<"Wrong entry in the mailing list \
                entry combo!";                      
mailinglistpropertiesdialog.cpp:    kWarning()<<"Wrong entry in the mailing list \
                entry combo!";                      
mailinglistpropertiesdialog.cpp:    kWarning()<<"Wrong entry in the mailing list \
entry combo!";                      

2: "Mailing-List" - count 9 
$ grep -i "Mailing-" *.cpp
kmmainwidget.cpp:  mListFilterAction->setText( i18n("Filter on Mailing-List...") );
kmmainwidget.cpp:    mListFilterAction->setText( i18n( "Filter on Mailing-List \
                %1...", lname ) );
kmmainwidget.cpp:                                          i18n( "New Message t&o \
                Mailing-List..." ),
kmmainwidget.cpp:  mListFilterAction = new KAction(i18n("Filter on \
                Mailing-&List..."), this);
kmsearchpatternedit.cpp: contain legitimate Mailing-List stuff
mailinglist-magic.cpp: contain legitimate Mailing-List stuff
mailinglist-magic.cpp:  QString header = message->headerField( "Mailing-List");
mailinglist-magic.cpp:  header_name = "Mailing-List";
messageactions.cpp:  mReplyListAction = new KAction( KIcon("mail-reply-list"), \
                i18n("Reply to Mailing-&List..."), this );
messageactions.cpp:  mMailingListActionMenu =  new \
                KActionMenu(i18nc("Message->","Mailing-&List" ), this);
searchwindow.cpp:  mReplyListAction  = new KAction(KIcon("mail-reply-list"), \
i18n("Reply to Mailing-&List..."), this);

To convert to "Mailing List"? I didn't want to be the one to upset the translators \
:-) sed -i -e "s/Mailing-/Mailing /g' kmmainwidget.cpp messageactions.cpp \
searchwindow.cpp


- Daniel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1768/#review2769
-----------------------------------------------------------


On 2009-10-22 14:37:57, Daniel Black wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1768/
> -----------------------------------------------------------
> 
> (Updated 2009-10-22 14:37:57)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> This patch displays the List{-ID,post,subscriber,unsubscribe,archive,help,owner} \
> RFC2369, List-ID is RFC2919 and Archived-At (RFC5064) URLs of email header fields \
> on header context of kmail preview pane. 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdepim/kmail/kmmainwidget.h 1038827 
> /trunk/KDE/kdepim/kmail/kmmainwidget.cpp 1038827 
> /trunk/KDE/kdepim/kmail/mailinglist-magic.h 1038827 
> /trunk/KDE/kdepim/kmail/mailinglist-magic.cpp 1038827 
> /trunk/KDE/kdepim/kmail/messageactions.h 1038827 
> /trunk/KDE/kdepim/kmail/messageactions.cpp 1038827 
> 
> Diff: http://reviewboard.kde.org/r/1768/diff
> 
> 
> Testing
> -------
> 
> tested on kmail-1.12.1 (kde-4.3.1)
> 
> 
> Screenshots
> -----------
> 
> kmail context menu with mailing list info
> http://reviewboard.kde.org/r/1768/s/233/
> 
> 
> Thanks,
> 
> Daniel
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]