[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request: adds kmail support for RFC2369,
From:       "Daniel Black" <daniel.subs () internode ! on ! net>
Date:       2009-10-22 22:19:12
Message-ID: 20091022221912.1143.36432 () localhost
[Download RAW message or body]



> On 2009-10-22 16:28:43, Thomas McGuire wrote:
> > /trunk/KDE/kdepim/kmail/messageactions.cpp, line 257
> > <http://reviewboard.kde.org/r/1768/diff/4/?file=13176#file13176line257>
> > 
> > Missing i18n in all these guys

this was at line 427 as I was assuming this was how phrases are done. Perhaps \
i18n("Contact Owner (") + protocol ")" is sufficient?


> On 2009-10-22 16:28:43, Thomas McGuire wrote:
> > /trunk/KDE/kdepim/kmail/messageactions.cpp, line 182
> > <http://reviewboard.kde.org/r/1768/diff/4/?file=13176#file13176line182>
> > 
> > Mailing-List Information is too long IMHO, just use "Mailing List" (also without \
> > the hyphen, since that is what is used in the folder menu)

Mailing-List" was chosen for consistency with "Reply to Mailing-List". Shortening is \
fine though Ingo is suggesting putting the List-id here too. Can submenu's have \
header text? Either that or "Mailing-List - KDE PIM". I could drop it but sometimes \
there is good information here as to what the specific list topic is.


- Daniel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1768/#review2769
-----------------------------------------------------------


On 2009-10-22 14:37:57, Daniel Black wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1768/
> -----------------------------------------------------------
> 
> (Updated 2009-10-22 14:37:57)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> This patch displays the List{-ID,post,subscriber,unsubscribe,archive,help,owner} \
> RFC2369, List-ID is RFC2919 and Archived-At (RFC5064) URLs of email header fields \
> on header context of kmail preview pane. 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdepim/kmail/kmmainwidget.h 1038827 
> /trunk/KDE/kdepim/kmail/kmmainwidget.cpp 1038827 
> /trunk/KDE/kdepim/kmail/mailinglist-magic.h 1038827 
> /trunk/KDE/kdepim/kmail/mailinglist-magic.cpp 1038827 
> /trunk/KDE/kdepim/kmail/messageactions.h 1038827 
> /trunk/KDE/kdepim/kmail/messageactions.cpp 1038827 
> 
> Diff: http://reviewboard.kde.org/r/1768/diff
> 
> 
> Testing
> -------
> 
> tested on kmail-1.12.1 (kde-4.3.1)
> 
> 
> Screenshots
> -----------
> 
> kmail context menu with mailing list info
> http://reviewboard.kde.org/r/1768/s/233/
> 
> 
> Thanks,
> 
> Daniel
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]