[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-pim
Subject: Re: [Kde-pim] Review Request: adds kmail support for RFC2369,
From: "Thomas McGuire" <mcguire () kde ! org>
Date: 2009-10-13 20:20:40
Message-ID: 20091013202040.25471.54513 () localhost
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1768/#review2637
-----------------------------------------------------------
Ok, after thinking about this more and after seeing the comments to this, I believe \
using the links in the message is not the way to go. Sorry. The links are not needed \
99% of the time and they use a lot of space. They could be disabled by default, but \
that again makes no sense since the links would be used mainly by beginners, who \
might not figure out how to turn them on in the first place. For the same reason, I'm \
against using an additional style.
Instead of links in the mail itself, it might be an idea to add the actions to a menu \
some, like the context menu of the "To:" link, when that is a mailing list, or even \
the context menu of the message in the reader.
To summarize, I will not accept a patch that adds links to the message. Sorry that \
this response is so late, I should have thought about this right from the beginning.
- Thomas
On 2009-10-05 14:29:35, Daniel Black wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1768/
> -----------------------------------------------------------
>
> (Updated 2009-10-05 14:29:35)
>
>
> Review request for KDE PIM.
>
>
> Summary
> -------
>
> This patch displays the List{-ID,post,subscriber,unsubscribe,archive,help,owner} \
> (<a href="http://tools.ietf.org/html/rfc2369">RFC2369</a> List-ID is RFC2919) URLs \
> of email header fields on the view plane in kmail. The display occurs on styles: \
> Enterprise, Fancy, Standard, and Long. The format is:
> List: Linux Australia Post Unsubscribe(http mailto) Subscribe(http mailto) Archive \
> Help The Post, Archive and Help are links to the single URL present. The \
> Subscribe/Unsubcribe have two links so the http and mailto, extracted from the URL \
> protocol, are links to those two options. Only list tags that exist are show. \
> Visual separation from the title and Post.... is a bit weak. Is "List: List Title \
> <Post....>" better?
>
> Diffs
> -----
>
> /trunk/KDE/kdepim/kmail/headerstrategy.cpp 1031501
> /trunk/KDE/kdepim/kmail/headerstyle.cpp 1031501
> /trunk/KDE/kdepim/kmail/mailinglist-magic.h 1031501
> /trunk/KDE/kdepim/kmail/mailinglist-magic.cpp 1031501
>
> Diff: http://reviewboard.kde.org/r/1768/diff
>
>
> Testing
> -------
>
> tested on kmail-1.12.1 (kde-4.3.1)
>
>
> Screenshots
> -----------
>
> Enterprise Style
> http://reviewboard.kde.org/r/1768/s/224/
> Fancy Style
> http://reviewboard.kde.org/r/1768/s/225/
> Long Style
> http://reviewboard.kde.org/r/1768/s/226/
>
>
> Thanks,
>
> Daniel
>
>
_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic