[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request: adds kmail support for RFC2369,
From:       "Markus Slopianka" <kamikazow () web ! de>
Date:       2009-10-10 19:29:56
Message-ID: 20091010192956.23368.52855 () localhost
[Download RAW message or body]



> On 2009-10-08 15:30:08, Thomas McGuire wrote:
> > I agree that this needs a configure option before this patch can be applied.
> > Fortunately, there is enough space in the message window configure tab for an \
> > other checkbox :) In addition, it might be an idea to have these list links at \
> > the bottom of a mail, not at the top. Not sure if that is better, though, just an \
> > opinion. 
> > As usual, I have made some inline comments below, please have a look at them.

> Fortunately, there is enough space in the message window configure tab for an other \
> checkbox :)

No, please not that way. It just adds clutter to a place where IMHO it doesn't even \
belong. Which header information is displayed, is already handled by the theme. Why \
should this be the only exception? I suggest a single, special mailing list header \
theme ("Decorative for mailing lists") as interim solution until the new theming \
engine is implemented. Once that is done, there will probably a theme config tab \
somewhere anyway.


- Markus


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1768/#review2589
-----------------------------------------------------------


On 2009-10-05 14:29:35, Daniel Black wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1768/
> -----------------------------------------------------------
> 
> (Updated 2009-10-05 14:29:35)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> This patch displays the List{-ID,post,subscriber,unsubscribe,archive,help,owner} \
> (<a href="http://tools.ietf.org/html/rfc2369">RFC2369</a> List-ID is RFC2919) URLs \
> of email header fields on the view plane in kmail. The display occurs on styles: \
>                 Enterprise, Fancy, Standard, and Long. The format is:
> List: Linux Australia  Post Unsubscribe(http mailto) Subscribe(http mailto) Archive \
> Help  The Post, Archive and Help are links to the single URL present. The \
> Subscribe/Unsubcribe have two links so the http and mailto, extracted from the URL \
> protocol, are links to those two options. Only list tags that exist are show. \
> Visual separation from the title and Post.... is a bit weak. Is "List: List Title \
> <Post....>" better? 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdepim/kmail/headerstrategy.cpp 1031501 
> /trunk/KDE/kdepim/kmail/headerstyle.cpp 1031501 
> /trunk/KDE/kdepim/kmail/mailinglist-magic.h 1031501 
> /trunk/KDE/kdepim/kmail/mailinglist-magic.cpp 1031501 
> 
> Diff: http://reviewboard.kde.org/r/1768/diff
> 
> 
> Testing
> -------
> 
> tested on kmail-1.12.1 (kde-4.3.1)
> 
> 
> Screenshots
> -----------
> 
> Enterprise Style
> http://reviewboard.kde.org/r/1768/s/224/
> Fancy Style
> http://reviewboard.kde.org/r/1768/s/225/
> Long Style
> http://reviewboard.kde.org/r/1768/s/226/
> 
> 
> Thanks,
> 
> Daniel
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]