From kde-pim  Tue Sep 29 18:57:02 2009
From: Ingo =?iso-8859-1?q?Kl=F6cker?= <kloecker () kde ! org>
Date: Tue, 29 Sep 2009 18:57:02 +0000
To: kde-pim
Subject: Re: [Kde-pim] Review Request: Ported KTimeTracker to KNotification
Message-Id: <200909292057.08031 () thufir ! ingo-kloecker ! de>
X-MARC-Message: https://marc.info/?l=kde-pim&m=125425069104734
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--===============0778033737=="

--===============0778033737==
Content-type: multipart/signed; boundary=nextPart2045182.Icdufmcj2p;
 protocol="application/pgp-signature"; micalg=pgp-sha1
Content-transfer-encoding: 7bit

--nextPart2045182.Icdufmcj2p
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

On Tuesday 29 September 2009, thorsten@staerk.de wrote:
> >> On 2009-09-29 05:32:23, Thorsten Staerk wrote:
> >> > I committed the change, see
> >>
> >> http://websvn.kde.org/?view=3Drevision&revision=3D1029142. Where can I
> >> set this to completed?
> >
> > there is somewhere a button here that lets you set this to
> > submitted.
>
> Do you mean the "ship it" tag? I did set that.

No. AFAIK only the original submitter of the review request can close=20
it.


Regards,
Ingo


> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > http://reviewboard.kde.org/r/1653/#review2495
> > -----------------------------------------------------------
> >
> > On 2009-09-19 20:16:41, Davide Bettio wrote:
> >> -----------------------------------------------------------
> >> This is an automatically generated e-mail. To reply, visit:
> >> http://reviewboard.kde.org/r/1653/
> >> -----------------------------------------------------------
> >>
> >> (Updated 2009-09-19 20:16:41)
> >>
> >>
> >> Review request for KDE PIM and Plasma.
> >>
> >>
> >> Summary
> >> -------
> >>
> >> KTimeTracker has been ported to KNotificationItem but I still have
> >> few issues that I've corrected with #if 0.
> >> It's not really clear to me how the notification works when
> >> KTimeTracker is a KPart.
> >> Anyway please don't use XPM pixmaps, use icons.
> >>
> >>
> >> Diffs
> >> -----
> >>
> >>   /trunk/KDE/kdepim/ktimetracker/ktimetrackerpart.cpp 1024122
> >>   /trunk/KDE/kdepim/ktimetracker/tray.h 1024122
> >>   /trunk/KDE/kdepim/ktimetracker/tray.cpp 1024122
> >>
> >> Diff: http://reviewboard.kde.org/r/1653/diff
> >>
> >>
> >> Testing
> >> -------
> >>
> >>
> >> Thanks,
> >>
> >> Davide
>
> _______________________________________________
> KDE PIM mailing list kde-pim@kde.org
> https://mail.kde.org/mailman/listinfo/kde-pim
> KDE PIM home page at http://pim.kde.org/

--nextPart2045182.Icdufmcj2p
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)

iEYEABECAAYFAkrCWIMACgkQGnR+RTDgudizjwCgrkkDcPKYY8MekW7mz1rH78lC
c9QAoIqjIKyo7GqK/6hnGD1vAPLMgqxL
=NBoI
-----END PGP SIGNATURE-----

--nextPart2045182.Icdufmcj2p--

--===============0778033737==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
--===============0778033737==--