[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-pim
Subject: Re: [Kde-pim] Review Request: Ported KTimeTracker to KNotification
From: "Davide Bettio" <davide.bettio () kdemail ! net>
Date: 2009-09-28 9:13:46
Message-ID: 20090928091346.32444.40039 () localhost
[Download RAW message or body]
> On 2009-09-21 13:41:29, Thorsten Staerk wrote:
> > Good to see you working on my baby ktimetracker. Let's have a discussion on irc.
>
> Davide Bettio wrote:
> ok. my timezone is CET. I'm on IRC in the afternoon and in the night. You can find \
> me in #plasma.
> Thorsten Staerk wrote:
> Did not work - most important question: What does your patch do? What issues do you \
> have? Which are fixed?
> Thorsten Staerk wrote:
> In bug 208099 https://bugs.kde.org/show_bug.cgi?id=208099 I recommend to test your \
> patch, but it does not build cleanly. Can you write a clean patch please?
This patch replaces KSysTrayIcon (that is deprecated) with KNotificationItem. For \
more information you should read Aaaron and Notmart blogs about it.
- Davide
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1653/#review2411
-----------------------------------------------------------
On 2009-09-19 20:16:41, Davide Bettio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1653/
> -----------------------------------------------------------
>
> (Updated 2009-09-19 20:16:41)
>
>
> Review request for KDE PIM and Plasma.
>
>
> Summary
> -------
>
> KTimeTracker has been ported to KNotificationItem but I still have few issues that \
> I've corrected with #if 0. It's not really clear to me how the notification works \
> when KTimeTracker is a KPart. Anyway please don't use XPM pixmaps, use icons.
>
>
> Diffs
> -----
>
> /trunk/KDE/kdepim/ktimetracker/ktimetrackerpart.cpp 1024122
> /trunk/KDE/kdepim/ktimetracker/tray.h 1024122
> /trunk/KDE/kdepim/ktimetracker/tray.cpp 1024122
>
> Diff: http://reviewboard.kde.org/r/1653/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Davide
>
>
_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic