[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request: Return error when email address ends
From:       "Thomas McGuire" <mcguire () kde ! org>
Date:       2009-08-26 17:22:27
Message-ID: 20090826172227.32307.15943 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1409/#review2155
-----------------------------------------------------------

Ship it!


I'd prefer the _data() method for unit tests, see \
http://techbase.kde.org/Development/Tutorials/Unittests#Tutorial_2:_Data_driven_testing_of_a_date_class
 But since those are only unit tests, it doesn't matter much.


/trunk/KDE/kdepimlibs/kpimutils/email.cpp
<http://reviewboard.kde.org/r/1409/#comment1472>

    coding style: missing whitespace :)


- Thomas


On 2009-08-26 11:57:12, Torgny Nyblom wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1409/
> -----------------------------------------------------------
> 
> (Updated 2009-08-26 11:57:12)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Check if an email address ends with '.'. If this is the case return an error.
> Add unit tests for this as well as for the "isValidAddressList()" function.
> 
> 
> This addresses bug 139477.
> https://bugs.kde.org/show_bug.cgi?id=139477
> 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdepimlibs/kpimutils/email.cpp 1015049 
> /trunk/KDE/kdepimlibs/kpimutils/tests/testemail.cpp 1015049 
> 
> Diff: http://reviewboard.kde.org/r/1409/diff
> 
> 
> Testing
> -------
> 
> Unit tests work.
> Sent email with correct and incorrect (returned error :)) address.
> 
> 
> Thanks,
> 
> Torgny
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]