[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-pim
Subject: Re: [Kde-pim] Review Request: zoom support for all tabs in akregator
From: "Frank Osterfeld" <frank.osterfeld () gmail ! com>
Date: 2009-07-31 19:21:47
Message-ID: 20090731192147.22483.24183 () localhost
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1104/#review1872
-----------------------------------------------------------
Ship it!
Thanks, committed!
Did some minor changes to the patch, like adding const for getters, checking for \
part/currentframe not null, etc.
- Frank
On 2009-07-27 18:56:06, Alexander Elbs wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1104/
> -----------------------------------------------------------
>
> (Updated 2009-07-27 18:56:06)
>
>
> Review request for KDE PIM.
>
>
> Summary
> -------
>
> - Move zoom action into tabwidget and send zoom in/out signals to all tabs. I \
> didn't find out how to tell a readonly part to zoom, so I casted it to khtmlpart \
> (if the part is khtml). Could be extended for other types.
> - Tabs load/save zoom factor
> - Add zoom in/out entries in popup menu for tabs.
> - Remove dead code (scroll up/down)
> - Fix typo in signal name (UserActionTakingPlace)
>
>
> Diffs
> -----
>
> branches/KDE/4.3/kdepim/akregator/src/actionmanagerimpl.cpp 1003140
> branches/KDE/4.3/kdepim/akregator/src/articleviewer.h 1003140
> branches/KDE/4.3/kdepim/akregator/src/articleviewer.cpp 1003140
> branches/KDE/4.3/kdepim/akregator/src/browserframe.h 1003140
> branches/KDE/4.3/kdepim/akregator/src/browserframe.cpp 1003140
> branches/KDE/4.3/kdepim/akregator/src/mainwidget.cpp 1003140
> branches/KDE/4.3/kdepim/akregator/src/tabwidget.h 1003140
> branches/KDE/4.3/kdepim/akregator/src/tabwidget.cpp 1003140
>
> Diff: http://reviewboard.kde.org/r/1104/diff
>
>
> Testing
> -------
>
> - opened tabs
> - ctrl-+, ctrl-- zoom in/out in current tab
> - same for popup menu and menu.
> - opening/closing tabs: still current tab is zoomed.
> - closing akregator, opening akreagtor: zoom factor for all tabs except \
> articleviewer is restored
>
> Thanks,
>
> Alexander
>
>
_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic