[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-pim
Subject: Re: [Kde-pim] Review Request: new kmail filter : add to address book
From: "Bruno Bigras" <bigras.bruno () gmail ! com>
Date: 2009-07-27 9:43:10
Message-ID: 20090727094310.22609.5960 () localhost
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1038/
-----------------------------------------------------------
(Updated 2009-07-27 09:43:10.546462)
Review request for KDE PIM.
Changes
-------
I updated the patch with a solution for the UI problem. As suggested by mjansen on \
irc I got rid of the QStackedWidget.
If you only want to see the new changes : http://pastebin.com/f376bc7b7
Surprisingly the deletes don't make kmail crash even if there's not check if \
gl->itemAtPosition( 1, 2 )->widget() is valid.
I'm also not sure about those comments edit but we'll see first if the proposed \
solution is good.
Summary
-------
This is a port of a commit by Christian Schaarschmidt \
https://bugs.kde.org/show_bug.cgi?id=47333#c19 from the kdepim-3.5.5+ branch.
It add an "add to address book" filter action.
I tried to make the ui look better when the window is not maximized (see the two \
screenshots) but the first combo box (the one to select "From", "To", "CC", "BCC") \
don't look so good in the center.
This addresses bug 47333.
https://bugs.kde.org/show_bug.cgi?id=47333
Diffs (updated)
-----
/trunk/KDE/kdepim/kmail/kmfilteraction.cpp 1002846
/trunk/KDE/kdepim/kmail/kmfilterdlg.h 1002846
/trunk/KDE/kdepim/kmail/kmfilterdlg.cpp 1002846
Diff: http://reviewboard.kde.org/r/1038/diff
Testing
-------
I tested this successfully when receiving emails and when sending to multiples \
recipients.
Screenshots
-----------
before
http://reviewboard.kde.org/r/1038/s/143/
after
http://reviewboard.kde.org/r/1038/s/144/
after-QGridLayout
http://reviewboard.kde.org/r/1038/s/148/
Thanks,
Bruno
_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic