[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request: new kmail filter : add to address book
From:       "Bruno Bigras" <bigras.bruno () gmail ! com>
Date:       2009-07-25 6:13:36
Message-ID: 20090725061336.24163.5949 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1038/
-----------------------------------------------------------

(Updated 2009-07-25 06:13:35.202603)


Review request for KDE PIM.


Summary
-------

This is a port of a commit by Christian Schaarschmidt \
https://bugs.kde.org/show_bug.cgi?id=47333#c19 from the kdepim-3.5.5+ branch.

It add an "add to address book" filter action.

I tried to make the ui look better when the window is not maximized (see the two \
screenshots) but the first combo box (the one to select "From", "To", "CC", "BCC") \
don't look so good in the center.


This addresses bug 47333.
    https://bugs.kde.org/show_bug.cgi?id=47333


Diffs (updated)
-----

  /trunk/KDE/kdepim/kmail/kmfilteraction.cpp 1002105 

Diff: http://reviewboard.kde.org/r/1038/diff


Testing
-------

I tested this successfully when receiving emails and when sending to multiples \
recipients.


Screenshots
-----------

before
  http://reviewboard.kde.org/r/1038/s/143/
after
  http://reviewboard.kde.org/r/1038/s/144/
after-QGridLayout
  http://reviewboard.kde.org/r/1038/s/148/


Thanks,

Bruno

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]