[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request: akonadi imapresource: Honor message
From:       "Tom Albers" <toma () kde ! org>
Date:       2009-07-16 18:32:34
Message-ID: 20090716183234.12860.12174 () localhost
[Download RAW message or body]



> On 2009-07-16 14:29:37, Volker Krause wrote:
> > This has been fixed already, right?

In theory yes. I can't check as the imap resource is currently broken for me. I'll \
close this anyhow.


- Tom


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/899/#review1622
-----------------------------------------------------------


On 2009-06-27 13:58:01, Tom Albers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/899/
> -----------------------------------------------------------
> 
> (Updated 2009-06-27 13:58:01)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> resultingFlags on the KIMAP side stored based on job id. And the resource is \
> retrieving it based on the uid of the message. 
> Hence line 348 of imapresource.cpp setting the flags to a random / but most likely \
> empty set, so losing all the flags again. 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdepimlibs/kimap/storejob.cpp 987865 
> 
> Diff: http://reviewboard.kde.org/r/899/diff
> 
> 
> Testing
> -------
> 
> Mailody has shortcuts to set custom colors on messages, shortcut 1-7, after doing \
> that first the selected color was honored, and after the roundtrip to the server \
> that change was lost again. After this patch the color remains. 
> 
> Thanks,
> 
> Tom
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]