[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request: Improve  focus handling (akregator)
From:       "Frank Osterfeld" <frank.osterfeld () gmail ! com>
Date:       2009-07-14 14:01:55
Message-ID: 20090714140155.30714.23668 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1002/#review1585
-----------------------------------------------------------

Ship it!


Thanks! I applied the focus part. For the "switch to maintab on next/prev article", \
it was actually already fixed in the 4.2  branch, so I forwardported the fix.

- Frank


On 2009-07-12 19:43:33, Alexander Elbs wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1002/
> -----------------------------------------------------------
> 
> (Updated 2009-07-12 19:43:33)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> - Force focus to always reach the articleviewer, even if in subscriptionlist has \
>                 been clicked, fixes bug 124486
> - If another tab is active and next/prev article is choosen activate tab 0 (article \
> list+view) 
> (Feel free to commit if patch is good, no svn account.)
> 
> 
> This addresses bug 124486.
> https://bugs.kde.org/show_bug.cgi?id=124486
> 
> 
> Diffs
> -----
> 
> trunk/KDE/kdepim/akregator/src/actionmanager.h 988800 
> trunk/KDE/kdepim/akregator/src/actionmanagerimpl.h 988800 
> trunk/KDE/kdepim/akregator/src/actionmanagerimpl.cpp 988800 
> trunk/KDE/kdepim/akregator/src/articlelistview.h 988800 
> trunk/KDE/kdepim/akregator/src/articlelistview.cpp 988800 
> trunk/KDE/kdepim/akregator/src/mainwidget.cpp 988800 
> trunk/KDE/kdepim/akregator/src/subscriptionlistview.cpp 988800 
> 
> Diff: http://reviewboard.kde.org/r/1002/diff
> 
> 
> Testing
> -------
> 
> - Keys like Up, Down, Pgup, Pgdown always reach the khtml part.
> - Left, Right, +, - switch back to tab 0
> 
> 
> Thanks,
> 
> Alexander
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]