[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request: Ensure that at least one column is
From:       "Frank Osterfeld" <frank.osterfeld () gmail ! com>
Date:       2009-06-28 18:28:15
Message-ID: 20090628182815.31007.58530 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/890/#review1407
-----------------------------------------------------------

Ship it!


Looks good, please commit to 4.3 and trunk.

- Frank


On 2009-06-25 14:25:06, Olivier Trichet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/890/
> -----------------------------------------------------------
> 
> (Updated 2009-06-25 14:25:06)
> 
> 
> Review request for KDE PIM and Frank Osterfeld.
> 
> 
> Summary
> -------
> 
> With this change, it should not be possible to remove every column of any view of \
> Akregator. 
> In the list of feeds (left pane), the "title" column can not be removed. Who would \
> want to do this anyway? In the list of post, if only one column is left, its \
> hidding is desactivated. 
> If someone managed to remove every columns (or has done so in a current version), \
> at least one column is displayed again on restart. 
> 
> This addresses bug 184960.
> https://bugs.kde.org/show_bug.cgi?id=184960
> 
> 
> Diffs
> -----
> 
> trunk/KDE/kdepim/akregator/src/articlelistview.cpp 986393 
> trunk/KDE/kdepim/akregator/src/subscriptionlistview.cpp 986393 
> 
> Diff: http://reviewboard.kde.org/r/890/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Olivier
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]