[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request: Improve error message when sending
From:       "Frank Osterfeld" <frank.osterfeld () gmail ! com>
Date:       2009-05-27 7:03:56
Message-ID: 20090527070356.9189.41240 () localhost
[Download RAW message or body]



> On 2009-05-26 15:35:47, Frank Osterfeld wrote:
> > Two remarks:
> > 
> > WA_DeleteOnClose must be set on the dialog now, not the widget. the widget is \
> > deleted when the dialog is deleted, but not vice-versa. 
> > I don't understand the addClicked() signal to slot change, did you omit the .cpp \
> > from the diff? 
> > 
> 
> Jonathan Armond wrote:
> So the dialog takes ownership?
> 
> I refer to addClicked() in transportmanagementwidget.h. It was a private slot, I \
> changed it to public slot so I could call it after creating the dialog. Is that \
> allowed? 
> Thanks

The dialog takes ownership, yes, as it is the parent of the widget.
addClicked(): Nevermind, I somehow misread and thought you moved it from signals to \
slots.


- Frank


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/762/#review1213
-----------------------------------------------------------


On 2009-05-26 12:43:50, Jonathan Armond wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/762/
> -----------------------------------------------------------
> 
> (Updated 2009-05-26 12:43:50)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Error message when sending with no outgoing account changed to a question asking \
> whether user wants to create one now. If yes, opens the transport management widget \
> to create outgoing account. 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdepim/kmail/util.cpp 973014 
> /trunk/KDE/kdepimlibs/mailtransport/transportmanagementwidget.h 972377 
> 
> Diff: http://reviewboard.kde.org/r/762/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jonathan
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]