[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request: Replaced KPassivePopup with
From:       "Tom Albers" <toma () kde ! org>
Date:       2009-05-21 20:28:23
Message-ID: 20090521202823.9008.87390 () localhost
[Download RAW message or body]



> On 2009-05-21 08:34:57, Tom Albers wrote:
> > /trunk/KDE/kdepim/akonadi/tray/org.freedesktop.akonaditray.xml, line 9
> > <http://reviewboard.kde.org/r/732/diff/1/?file=6544#file6544line9>
> > 
> > That means you need to change the akonadi agentbase.cpp or resourcebase.cpp files \
> > to not use this api, right? 
> > And the question is if this breaks API. I think it does, so a convenience \
> > function to merge those two might be a better solution.
> 
> wrote:
> I'd say the real question is: why remove the title at all?
> 
> 
> wrote:
> According to the apidoc we can't display the title using KNotification::event.
> We can choose to ignore the title parameter or we may ask to add a new parameter to \
> KNotification::event. 

Please do, as it would make things nicer....


- Tom


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/732/#review1167
-----------------------------------------------------------


On 2009-05-21 07:04:35, Davide Bettio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/732/
> -----------------------------------------------------------
> 
> (Updated 2009-05-21 07:04:35)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> I've replaced KPassivePopups with KNotifications.
> 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdepim/akonadi/tray/dock.h 970973 
> /trunk/KDE/kdepim/akonadi/tray/dock.cpp 970973 
> /trunk/KDE/kdepim/akonadi/tray/org.freedesktop.akonaditray.xml 970973 
> 
> Diff: http://reviewboard.kde.org/r/732/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Davide
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]