[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request: sometimes event's are displayed in
From:       "Sergio Martins" <iamsergio () gmail ! com>
Date:       2009-05-05 22:46:47
Message-ID: 20090505224647.13585.11547 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/674/#review1066
-----------------------------------------------------------


int eventDuration = incDtStart.daysTo( incDtEnd )

This also will give different results depending on the timespec used.

I'll post a new patch.

- Sergio


On 2009-05-05 14:45:58, Sergio Martins wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/674/
> -----------------------------------------------------------
> 
> (Updated 2009-05-05 14:45:58)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> I found a problem when displaying incidences in agendaview/monthview/navigator, \
> probably introduced with the performance improvements in 4.1.4. 
> When converting a KDateTime to QDate we are using the incidence's timezone, and not \
> the user's timezone, so, if you have an incidence with DTSTART=10-January-2009 \
> 01h00 UTC, and you live in America/Denver, you should see the event at \
> 09-January-2009, not at 10th. 
> 
> This addresses bug 182323.
> https://bugs.kde.org/show_bug.cgi?id=182323
> 
> 
> Diffs
> -----
> 
> trunk/KDE/kdepim/korganizer/kodaymatrix.cpp 961824 
> trunk/KDE/kdepim/korganizer/views/agendaview/koagendaview.cpp 962393 
> trunk/KDE/kdepim/korganizer/views/monthview/monthview.cpp 962393 
> 
> Diff: http://reviewboard.kde.org/r/674/diff
> 
> 
> Testing
> -------
> 
> I still must check where does mCalendar->timezone() come from, and if it's always \
> equal to KOPrefs's timezone. 
> 
> Thanks,
> 
> Sergio
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]