[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request: Fix for kcal's
From:       "David Jarvie" <djarvie () kde ! org>
Date:       2009-05-05 8:05:35
Message-ID: 20090505080535.26570.5534 () localhost
[Download RAW message or body]



> On 2009-05-03 17:38:38, David Jarvie wrote:
> > trunk/KDE/kdepimlibs/kcal/recurrence.cpp, line 955
> > <http://reviewboard.kde.org/r/651/diff/3/?file=5873#file5873line955>
> > 
> > I'm doubtful about this change. It changes the specification of the RDATE from a \
> > date-only value to a date/time value.
> 
> wrote:
> I didn't intend to change the old behavior. I reverted it to how it was before.
> 
> However it uses mStartDate's time and not date only.

That looks good now.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/651/#review1046
-----------------------------------------------------------


On 2009-05-04 13:49:24, Sergio Martins wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/651/
> -----------------------------------------------------------
> 
> (Updated 2009-05-04 13:49:24)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Fixes two problems with Recurrence::timesInInterval( start, end ) that are only \
> reproducible with events from lotus notes. 
> timesInInterval() was returning all dates in mRDates and mRDateTimes regardless if \
> they belonged to the interval [start, end]. 
> If the event had rdates but didn't have rrules, the first occurrence (the one \
> specified by dtstart) wasn't returned. 
> 
> This addresses bug 191221.
> https://bugs.kde.org/show_bug.cgi?id=191221
> 
> 
> Diffs
> -----
> 
> trunk/KDE/kdepimlibs/kcal/recurrence.cpp 955540 
> 
> Diff: http://reviewboard.kde.org/r/651/diff
> 
> 
> Testing
> -------
> 
> Tested event from bug 191221. Tested recurring events created with korganizer.
> 
> 
> Thanks,
> 
> Sergio
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]