[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request: Use the imapstreamparser in the
From:       Mantia Andras <amantia () kde ! org>
Date:       2009-03-16 19:13:06
Message-ID: 20090316190818.9DD38E6C79D () smykowski ! kdab ! net
[Download RAW message or body]

Andras Mantia wrote:

> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/301/
> -----------------------------------------------------------
> 
> (Updated 2009-03-14 10:39:19.559727)
> 
> 
> Review request for KDE PIM.
> 
> 
> Changes
> -------
> 
> Updated diff, the main changes are: Handler doesn't read the command and
> akonadiconnection has both the old and the new version of reading from
> socket. The reason is the failing unittest with the new version. I
> couldn't find why it fails when run via ctest, and not when running
> individually. Use ctest -I 8,8 -V to see the failing test. It hangs after
> akonadi-TES(18088) SetupTest::resourceSynchronized: Agent
> "akonadi_knut_resource_1" synchronized.
> 
> The problem is somewhere in the case when the default handler is called,
> the old way also work ONLY if the command is not read from the buffer.
> 
> To enable the new code, uncomment the following lines:
> //  slotNewData2();
> //  return;
> 
> I'm clueless right now about the solution, ideas are welcome.

As the problem is solved, the unit tests pass now, and Volker OK'd it on 
IRC, I committed the code, from now on only the ImapStreamParser is used in 
the handlers.

Andras

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]