[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-pim
Subject: Re: [Kde-pim] Review Request: Cleaner CMakeLists.txt for KDEPIM
From: "Thomas McGuire" <mcguire () kde ! org>
Date: 2009-03-05 23:05:16
Message-ID: 20090305230516.32494.67151 () localhost
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/239/#review376
-----------------------------------------------------------
Ship it!
I like it! I've still not actually tried it though, but it looks like it will work :)
- Thomas
On 2009-03-05 14:59:37, Christophe Giboudeaux wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/239/
> -----------------------------------------------------------
>
> (Updated 2009-03-05 14:59:37)
>
>
> Review request for KDE PIM, Allen Winter and Thomas McGuire.
>
>
> Summary
> -------
>
>
> Goal:
> Make CMakeLists.txt human readable.
>
> Modifications:
> - Rename BUILD_EVERYTHING -> KDEPIM_BUILD_EVERYTHING
> - Rename ONLY_KLEO -> KDEPIM_ONLY_KLEO
> - Rename ENTREPRISE_BUILD -> KDEPIM_ENTREPRISE_BUILD
> - Rename KDE4_KDEPIM_NEW_DISTRLISTS -> KDEPIM_NEW_DISTRLISTS
> - Rename TOPOLOGICAL_SORT_DIR -> Boost_TOPOLOGICAL_SORT_DIR
>
> This way, these options/items will be grouped in the CMakeCache file and in the \
> cmake GUI app (see screenshot)
> - Make QGpgme required even if KDEPIM_ONLY_KLEO is false.
> - Remove the Kode checks
> - Move the X11_Xscreensaver to KTimetracker's own CMakeLists. Since it is not a \
> hard requirement, allow Ktimetracker to be built under Windows (*)
> - Replace add_definitions(-DFOO_SUPPORTED) with macro_bool_to_01
> - Clean as much as possible
>
> TODO:
> - Move the libknotesresources_SRCS, libknoteseditor_SRCS, libkdgantt1_SRCS in a \
> better place.
> - If accepted, also rename the options in kdepimlibs before commiting.
>
> (*) Testing needed.
>
>
> Diffs
> -----
>
> trunk/KDE/kdepim/CMakeLists.txt 935687
> trunk/KDE/kdepim/config-enterprise.h.cmake 935687
> trunk/KDE/kdepim/doc/CMakeLists.txt 935687
> trunk/KDE/kdepim/kleopatra/CMakeLists.txt 935687
> trunk/KDE/kdepim/kleopatra/conf/CMakeLists.txt 935687
> trunk/KDE/kdepim/kleopatra/conf/appearanceconfigwidget.cpp 935687
> trunk/KDE/kdepim/kleopatra/mainwindow.cpp 935687
> trunk/KDE/kdepim/kleopatra/tests/CMakeLists.txt 935687
> trunk/KDE/kdepim/kmail/CMakeLists.txt 935687
> trunk/KDE/kdepim/kmail/configuredialog.cpp 935687
> trunk/KDE/kdepim/kmail/configuredialog_p.h 935687
> trunk/KDE/kdepim/kresources/CMakeLists.txt 935687
> trunk/KDE/kdepim/ktimetracker/CMakeLists.txt 935687
> trunk/KDE/kdepim/libkleo/CMakeLists.txt 935687
> trunk/KDE/kdepim/libkleo/kleo/cryptobackendfactory.cpp 935687
> trunk/KDE/kdepim/libkleo/ui/cryptoconfigmodule.cpp 935687
> trunk/KDE/kdepim/libkleo/ui/messagebox.cpp 935687
> trunk/KDE/kdepim/libkpgp/pics/CMakeLists.txt 935687
> trunk/KDE/kdepim/wizards/CMakeLists.txt 935687
>
> Diff: http://reviewboard.kde.org/r/239/diff
>
>
> Testing
> -------
>
>
> Screenshots
> -----------
>
>
> http://reviewboard.kde.org/r/239/s/49/
>
>
> Thanks,
>
> Christophe
>
>
_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic