[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request: Refactor the formatting functions
From:       "Allen Winter" <winter () kde ! org>
Date:       2009-02-21 18:03:12
Message-ID: 20090221180312.11747.87919 () localhost
[Download RAW message or body]



> On 2009-02-21 08:22:50, Allen Winter wrote:
> > trunk/KDE/kdepimlibs/kcal/incidenceformatter.h, line 188
> > <http://reviewboard.kde.org/r/134/diff/1/?file=839#file839line188>
> > 
> > how about calling this dateTimeToStr() instead?  i.e. don't make it specific to \
> > an event, especially since its being used to print a to-do due date. 
> > mention in the apidox that printing to-do start/due or journal start should \
> > always pass allday=true.
> 
> wrote:
> How about using "String" instead of "Str". Makes them more consistent with \
> toString() methods of other classes. 
> And probably get rid of the booleans in favor of using flags for improving \
> readability of calls to these methods?

Csaba, I agree with Kevin.  Those are good suggestions.


- Allen


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/134/#review214
-----------------------------------------------------------


On 2009-02-20 05:16:09, Csaba Kertész wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/134/
> -----------------------------------------------------------
> 
> (Updated 2009-02-20 05:16:09)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Move the rest formatting functions to incidenceformatter class inside KCal
> 
> 
> Diffs
> -----
> 
> trunk/KDE/kdepimlibs/kcal/htmlexport.cpp 924164 
> trunk/KDE/kdepimlibs/kcal/incidenceformatter.h 924164 
> trunk/KDE/kdepimlibs/kcal/incidenceformatter.cpp 924164 
> 
> Diff: http://reviewboard.kde.org/r/134/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Csaba
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]