From kde-pim Mon Feb 16 18:31:04 2009 From: "Jonathan Marten" Date: Mon, 16 Feb 2009 18:31:04 +0000 To: kde-pim Subject: [Kde-pim] Review Request: Allow creation of new top level folder in Message-Id: <20090216183104.17024.51301 () localhost> X-MARC-Message: https://marc.info/?l=kde-pim&m=123480937919780 ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/105/ ----------------------------------------------------------- Review request for KDE PIM. Summary ------- Fix for the old problem of not being able to create a new subfolder in certain places when using the folder selection tree view - in particular, not being able to create a new top level local folder. Also tidied up the operation of this dialogue, centralising the decisions in FolderSelectionTreeWidget instead of having them duplicated in FolderSelectionDialog. Changed the signal/slot connections between the two. Use a KAction for the popup menu and enable/disable it as required. Disable the "OK" button in the dialogue where it is not allowed. Previously a folder with "No Content", e.g. the "Local Folders" or an IMAP root, could be selected as a filter or move/copy destination. This addresses bug 128796. https://bugs.kde.org/show_bug.cgi?id=128796 Diffs ----- trunk/KDE/kdepim/kmail/folderselectiondialog.h 926798 trunk/KDE/kdepim/kmail/folderselectiondialog.cpp 926798 trunk/KDE/kdepim/kmail/folderselectiontreewidget.h 926798 trunk/KDE/kdepim/kmail/folderselectiontreewidget.cpp 926798 Diff: http://reviewboard.kde.org/r/105/diff Testing ------- Checked operation of all uses of FolderSelectionDialog or FolderRequester for correct enable/disable of "OK" and "New Subfolder" buttons. Checked creation of new subfolder where this is allowed. Thanks, Jonathan _______________________________________________ KDE PIM mailing list kde-pim@kde.org https://mail.kde.org/mailman/listinfo/kde-pim KDE PIM home page at http://pim.kde.org/