[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request: Improvement of QtConcurrent patch for
From:       "Thomas McGuire" <mcguire () kde ! org>
Date:       2009-02-05 9:59:59
Message-ID: 20090205100011.9097.39331 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/25/#review23
-----------------------------------------------------------


Just to be sure: That QEventloop you added is in no way connected to the event loop \
of the main thread, i.e. doesn't process any events of it, right? If that is so, I'd \
say the patch is fine.

Just one thing: You need to call waitForLaterDelete() before every return, seems like \
an easy thing to forget. Maybe use a nifty RAII template class instead, like: \
NiftyClass<ItemFetchJob> job = new ItemFetchJob( collection ); The destructor of \
NiftyClass would then do the waiting itself, so you don't have to call something \
before every return. But that might be overkill in this case.

- Thomas


On 2009-02-04 16:44:56, Kevin Krammer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/25/
> -----------------------------------------------------------
> 
> (Updated 2009-02-04 16:44:56)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Thinking about Thomas' comment about possible causes for the "application does not \
> complete quit" issue, I remembered that Akonadi jobs do a deleteLater() thing and \
> the worker thread's event loop might not have a chance to run after the worker \
> methods return. 
> So I am now using a dreaded :) nested event loop in the thread context to wait for \
> the job's destroyed() signal. Seems to work.
> 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdepim/kresources/akonadi/kabc/resourceakonadi.cpp 921044 
> 
> Diff: http://reviewboard.kde.org/r/25/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]