[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request: Minor changes to the copyright headers
From:       cgiboudeaux () gmail ! com
Date:       2009-02-04 15:51:28
Message-ID: 20090204155128.21905.75791 () localhost
[Download RAW message or body]



> On 2009-02-04 07:28:54, Allen Winter wrote:
> > looks fine. except we need a real license header instead of "...see the COPYING \
> > file..."  for the akregator sources.  I also didn't check the email addresses you \
> > added; I assume you did that.

The COPYING File in akregator only states about GPL v2 (without "or above" \
indication). This case isn't covered by the default headers on techbase \
(http://techbase.kde.org/Policies/Licensing_Policy).

Is this ok ?
    This program is free software; you can redistribute it and/or
    modify it under the terms of the GNU General Public License,
    version 2.0, as published by the Free Software Foundation.
    You should have received a copy of the GNU General Public License
    along with this program; if not, write to the Free Software Foundation,
    Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, US


About the email addresses, for markey, it's the one used in Amarok authors list, for \
tstaerk, it's the one used for other files (eg. plannerparser.cpp)


- cgiboudeaux


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/20/#review9
-----------------------------------------------------------


On 2009-02-04 07:12:08, cgiboudeaux wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/20/
> -----------------------------------------------------------
> 
> (Updated 2009-02-04 07:12:08)
> 
> 
> Review request for KDE PIM and cgiboudeaux.
> 
> 
> Summary
> -------
> 
> Minor and harmless changes to the copyright headers. Will make Krazy slightly more \
> happy 
> 
> Diffs
> -----
> 
> trunk/KDE/kdepim/akregator/interfaces/plugin.h 921089 
> trunk/KDE/kdepim/akregator/interfaces/plugin.cpp 921089 
> trunk/KDE/kdepim/akregator/src/dummystorage/storagedummyimpl.cpp 921089 
> trunk/KDE/kdepim/kmailcvt/filter_evolution.hxx 920850 
> trunk/KDE/kdepim/kmailcvt/filter_evolution.cxx 920850 
> trunk/KDE/kdepim/kmailcvt/filter_evolution_v2.hxx 920850 
> trunk/KDE/kdepim/kmailcvt/filter_evolution_v2.cxx 920850 
> trunk/KDE/kdepim/kmailcvt/filter_oe.cxx 920850 
> trunk/KDE/kdepim/kmailcvt/filter_pmail.cxx 920850 
> trunk/KDE/kdepim/ktimetracker/kcmconfigs/kcmktimetrackerconfig.h 921089 
> trunk/KDE/kdepim/ktimetracker/kcmconfigs/kcmktimetrackerconfig.cpp 921089 
> trunk/KDE/kdepim/ktimetracker/kcmconfigs/ktimetrackerconfigwidget.h 921089 
> 
> Diff: http://reviewboard.kde.org/r/20/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> cgiboudeaux
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]