[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] KMail Configuredialog
From:       Torgny Nyblom <kde () nyblom ! org>
Date:       2008-12-23 7:16:32
Message-ID: 200812230816.32919.kde () nyblom ! org
[Download RAW message or body]

On Monday 22 December 2008 21:32:02 Thomas McGuire wrote:
> Hi,
>
> sorry for the very late reply.
>
> On Wednesday 17 December 2008 21:32:42 Torgny Nyblom wrote:
> > I'm working on a patch to extract the ui code for configuredialog into
> > .ui files.
> >
> > How is this patch (and the rest as the other pages get converted)
> > affected by the string/feature freezes?

[...]
> The layout of the folders tab looks wrong. According to
> http://wiki.openusability.org/guidelines/index.php/Design_and_Layout:Layout
>:Dialogs, the labels should be right-aligned.
> In a general note, I would prefer first porting the dialogs 1:1 to UI
> files, committing, then doing layout changes. I agree that the current
> folders tab needs a layout overhaul.

Hmm, guess I need to take a second look at this. I was trying to do a 1:1 
conversion to ui files before changing anything else. But if my eyes don't 
deceive me the current layout is left aligned.

[lots of good point, that I need to address]

> As Ingo said, please commit right after the release when trunk is open
> again, and post a new patch addressing the issues. Looking forward to the
> patch.

Will do.

/Regards
Torgny
_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]