From kde-pim  Fri Aug 22 08:52:12 2008
From: Togge <togge.gentoo () gmail ! com>
Date: Fri, 22 Aug 2008 08:52:12 +0000
To: kde-pim
Subject: Re: [Kde-pim] [RFC, Patch] KMail account wizard
Message-Id: <200808221052.14047.togge.gentoo () gmail ! com>
X-MARC-Message: https://marc.info/?l=kde-pim&m=121939521116410

On Thursday 21 August 2008 23:28:04 Ingo Klöcker wrote:
> On Wednesday 20 August 2008, Togge wrote:
> > Fixed. It now uses a similar approach, ie using the surname as
> > identity name instead of the domain part of the email address.
>
> I suggest to use the email address instead. The most common reason for
[...]
Did this before committing.

> BTW. What happens if there is already an identity of the same name? Your
> code does not seem to handle this situation. It calls
> manager->newFromScratch( identityName() )
> without checking whether there is already an identity of the same name.

Have a patch for IdentityManager sitting here for that issue. Since there are 
functions to get an id by name it doesn't make sense to allow the same name 
for more then one id. Just need to get some feedback on this before 
committing.

/Regards
Torgny
_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/