From kde-pim  Thu Aug 21 10:06:32 2008
From: Frank Osterfeld <frank () kdab ! net>
Date: Thu, 21 Aug 2008 10:06:32 +0000
To: kde-pim
Subject: Re: [Kde-pim] [PATCH] Nice headers for akregator
Message-Id: <200808211206.32413.frank () kdab ! net>
X-MARC-Message: https://marc.info/?l=kde-pim&m=121931323607387

On Saturday 16 August 2008 22:24:34 Kolja wrote:

> The attached patch applies to the directory
> akregator/src, but only articleformatter.cpp is
> affected. It's meant for trunk.
>
> Comments and suggestions?! :)

I like the style, much more than the current one. We should have a consistent 
look between KMail and Akregator though, so I think I'd hold back the patch 
until that is solved.

Two code comments:

- The colors are hardcoded, that shouldn't be, the colors should be deducted 
from the color scheme and/or be configurable by the user.

- Is there a reason for QString( "%1:" ).arg( i18n("Homepage") instead of just 
i18n("Homepage:")?

Regards,

-- 
Frank Osterfeld -- frank@kdab.net
Klarälvdalens Datakonsult AB, Platform-independent software solutions
_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/