[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    [Kde-pim] [PATCH] Fix a D-Bus assert in libkleo
From:       Alex Merry <huntedhacker () tiscali ! co ! uk>
Date:       2008-07-14 10:40:42
Message-ID: 200807141140.42358.huntedhacker () tiscali ! co ! uk
[Download RAW message or body]

Currently, when configuring the security section of KMail, clicking Configure 
in the Crypto Backends tab and then clicking OK results in an assert in D-Bus:

arguments to dbus_message_new_signal() were incorrect, assertion "path != 
NULL"

Using the backtrace, I found the problem was that QString() was being passed 
as the path to QDBusMessage::createSignal() at line 316 of 
backendconfigwidget.cpp in libkleo/ui.

The attached patch changes it to "/", fixing the assert.

Alex


-- 
KDE: http://www.kde.org
Ubuntu/Kubuntu: http://www.ubuntu.org http://www.kubuntu.org


["libkleo-dbus-signal.diff" (text/x-patch)]

Index: backendconfigwidget.cpp
===================================================================
--- backendconfigwidget.cpp	(revision 832310)
+++ backendconfigwidget.cpp	(working copy)
@@ -312,7 +312,7 @@ void Kleo::BackendConfigWidget::slotConf
     if ( result == QDialog::Accepted ) {
       // Tell other users of gpgconf (e.g. the s/mime page) that the gpgconf data might have changed
       QDBusMessage message =
-          QDBusMessage::createSignal(QString(), "org.kde.kleo.CryptoConfig", "changed");
+          QDBusMessage::createSignal("/", "org.kde.kleo.CryptoConfig", "changed");
       QDBusConnection::sessionBus().send(message);
       
       // and schedule a rescan, in case the updates make a backend valid


_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

[prev in list] [next in list] [prev in thread] [next in thread]