From kde-pim Tue May 20 22:10:21 2008 From: =?UTF-8?B?SmFyb3PFgmF3IFN0YW5pZWs=?= Date: Tue, 20 May 2008 22:10:21 +0000 To: kde-pim Subject: Re: [Kde-pim] [patch] handling of static data in akonadi and Message-Id: <48334C4D.1040807 () iidea ! pl> X-MARC-Message: https://marc.info/?l=kde-pim&m=121132153013157 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--------------080901050104010005090903" This is a multi-part message in MIME format. --------------080901050104010005090903 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Ingo Klöcker said the following, On 2008-05-20 23:34: > Or just > > if ( s_slavePool.isDestroyed() ) { > return; > } > > I guess it doesn't really make much of a difference. deleteLater() will > most likely have no effect because event processing will already have > been stopped when s_slavePool is destroyed. Attached patch for this class only. -- regards / pozdrawiam, Jaroslaw Staniek Sponsored by OpenOffice Polska (http://www.openoffice.com.pl/en) to work on Kexi & KOffice (http://www.kexi.pl/en, http://www.koffice.org/kexi) KDE Libraries for MS Windows (http://windows.kde.org) --------------080901050104010005090903 Content-Type: text/plain; name="smtpjob.patch" Content-Transfer-Encoding: base64 Content-Disposition: inline; filename="smtpjob.patch" SW5kZXg6IG1haWx0cmFuc3BvcnQvc210cGpvYi5jcHANCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBt YWlsdHJhbnNwb3J0L3NtdHBqb2IuY3BwCSh3ZXJzamEgODEwMzEzKQ0KKysrIG1haWx0cmFu c3BvcnQvc210cGpvYi5jcHAJKGtvcGlhIHJvYm9jemEpDQpAQCAtMzYsMjAgKzM2LDI3IEBA DQogCiB1c2luZyBuYW1lc3BhY2UgTWFpbFRyYW5zcG9ydDsKIAotc3RhdGljIGludCBzbGF2 ZVBvb2xSZWYgPSAwOwotc3RhdGljIFFIYXNoPGludCxLSU86OlNsYXZlKj4gc2xhdmVQb29s Oworc3RydWN0IFNsYXZlUG9vbAoreworICBTbGF2ZVBvb2woKSA6IHJlZiggMCApIHt9Cisg IGludCByZWY7CisgIFFIYXNoPGludCxLSU86OlNsYXZlKj4gc2xhdmVzOwogCi1zdGF0aWMg dm9pZCByZW1vdmVTbGF2ZUZyb21Qb29sKCBLSU86OlNsYXZlICpzbGF2ZSwgYm9vbCBkaXNj b25uZWN0ID0gZmFsc2UgKQotewotICBjb25zdCBpbnQgc2xhdmVLZXkgPSBzbGF2ZVBvb2wu a2V5KCBzbGF2ZSApOwotICBpZiAoIHNsYXZlS2V5ID4gMCApIHsKLSAgICBzbGF2ZVBvb2wu cmVtb3ZlKCBzbGF2ZUtleSApOwotICAgIGlmICggZGlzY29ubmVjdCApIHsKLSAgICAgIEtJ Tzo6U2NoZWR1bGVyOjpkaXNjb25uZWN0U2xhdmUoIHNsYXZlICk7CisgIHZvaWQgcmVtb3Zl U2xhdmUoIEtJTzo6U2xhdmUgKnNsYXZlLCBib29sIGRpc2Nvbm5lY3QgPSBmYWxzZSApCisg IHsKKyAgICBjb25zdCBpbnQgc2xhdmVLZXkgPSBzbGF2ZXMua2V5KCBzbGF2ZSApOworICAg IGlmICggc2xhdmVLZXkgPiAwICkgeworICAgICAgc2xhdmVzLnJlbW92ZSggc2xhdmVLZXkg KTsKKyAgICAgIGlmICggZGlzY29ubmVjdCApIHsKKyAgICAgICAgS0lPOjpTY2hlZHVsZXI6 OmRpc2Nvbm5lY3RTbGF2ZSggc2xhdmUgKTsKKyAgICAgIH0KICAgICB9CiAgIH0KLX0KK307 CiAKK0tfR0xPQkFMX1NUQVRJQyggU2xhdmVQb29sLCBzX3NsYXZlUG9vbCApCisKKwogLyoq CiAgKiBQcml2YXRlIGNsYXNzIHRoYXQgaGVscHMgdG8gcHJvdmlkZSBiaW5hcnkgY29tcGF0 aWJpbGl0eSBiZXR3ZWVuIHJlbGVhc2VzLgogICogQGludGVybmFsCkBAIC03MCwyNyArNzcs MzMgQEANCiAgIGQtPmN1cnJlbnRTdGF0ZSA9IFNtdHBKb2JQcml2YXRlOjpJZGxlOwogICBk LT5zbGF2ZSA9IDA7CiAgIGQtPmZpbmlzaGVkID0gZmFsc2U7Ci0gIHNsYXZlUG9vbFJlZisr OworICBpZiAoICFzX3NsYXZlUG9vbC5pc0Rlc3Ryb3llZCgpICkKKyAgICBzX3NsYXZlUG9v bC0+cmVmKys7CiAgIEtJTzo6U2NoZWR1bGVyOjpjb25uZWN0KCBTSUdOQUwoc2xhdmVFcnJv cihLSU86OlNsYXZlKixpbnQsUVN0cmluZykpLAogICAgICAgICAgICAgICAgICAgICAgICAg ICAgdGhpcywgU0xPVChzbGF2ZUVycm9yKEtJTzo6U2xhdmUqLGludCxRU3RyaW5nKSkgKTsK IH0KIAogU210cEpvYjo6flNtdHBKb2IoKQogewotICBzbGF2ZVBvb2xSZWYtLTsKLSAgaWYg KCBzbGF2ZVBvb2xSZWYgPT0gMCApIHsKLSAgICBrRGVidWcoKSA8PCAiY2xlYXJpbmcgU01U UCBzbGF2ZSBwb29sIiA8PCBzbGF2ZVBvb2wuY291bnQoKTsKLSAgICBmb3JlYWNoICggS0lP OjpTbGF2ZSAqc2xhdmUsIHNsYXZlUG9vbC52YWx1ZXMoKSApIHsKLSAgICAgIEtJTzo6U2No ZWR1bGVyOjpkaXNjb25uZWN0U2xhdmUoIHNsYXZlICk7CisgIGlmICggIXNfc2xhdmVQb29s LmlzRGVzdHJveWVkKCkgKSB7CisgICAgc19zbGF2ZVBvb2wtPnJlZi0tOworICAgIGlmICgg c19zbGF2ZVBvb2wtPnJlZiA9PSAwICkgeworICAgICAga0RlYnVnKCkgPDwgImNsZWFyaW5n IFNNVFAgc2xhdmUgcG9vbCIgPDwgc19zbGF2ZVBvb2wtPnNsYXZlcy5jb3VudCgpOworICAg ICAgZm9yZWFjaCAoIEtJTzo6U2xhdmUgKnNsYXZlLCBzX3NsYXZlUG9vbC0+c2xhdmVzLnZh bHVlcygpICkgeworICAgICAgICBLSU86OlNjaGVkdWxlcjo6ZGlzY29ubmVjdFNsYXZlKCBz bGF2ZSApOworICAgICAgfQorICAgICAgc19zbGF2ZVBvb2wtPnNsYXZlcy5jbGVhcigpOwog ICAgIH0KLSAgICBzbGF2ZVBvb2wuY2xlYXIoKTsKICAgfQogICBkZWxldGUgZDsKIH0KIAog dm9pZCBTbXRwSm9iOjpkb1N0YXJ0KCkKIHsKLSAgaWYgKCBzbGF2ZVBvb2wuY29udGFpbnMo IHRyYW5zcG9ydCgpLT5pZCgpICkgfHwKKyAgaWYgKCBzX3NsYXZlUG9vbC5pc0Rlc3Ryb3ll ZCgpICkKKyAgICByZXR1cm47CisKKyAgaWYgKCBzX3NsYXZlUG9vbC0+c2xhdmVzLmNvbnRh aW5zKCB0cmFuc3BvcnQoKS0+aWQoKSApIHx8CiAgICAgICAgdHJhbnNwb3J0KCktPnByZWNv bW1hbmQoKS5pc0VtcHR5KCkgKSB7CiAgICAgZC0+Y3VycmVudFN0YXRlID0gU210cEpvYlBy aXZhdGU6OlNtdHA7CiAgICAgc3RhcnRTbXRwSm9iKCk7CkBAIC0xMDQsNiArMTE3LDkgQEAN CiAKIHZvaWQgU210cEpvYjo6c3RhcnRTbXRwSm9iKCkKIHsKKyAgaWYgKCBzX3NsYXZlUG9v bC5pc0Rlc3Ryb3llZCgpICkKKyAgICByZXR1cm47CisKICAgS1VybCBkZXN0aW5hdGlvbjsK ICAgZGVzdGluYXRpb24uc2V0UHJvdG9jb2woICggdHJhbnNwb3J0KCktPmVuY3J5cHRpb24o KSA9PSBUcmFuc3BvcnQ6OkVudW1FbmNyeXB0aW9uOjpTU0wgKSA/CiAgICAgICAgICAgICAg ICAgICAgICAgICAgICBTTVRQU19QUk9UT0NPTCA6IFNNVFBfUFJPVE9DT0wgKTsKQEAgLTE3 NCw3ICsxOTAsNyBAQA0KIAogICBkZXN0aW5hdGlvbi5zZXRQYXRoKCBRTGF0aW4xU3RyaW5n KCAiL3NlbmQiICkgKTsKIAotICBkLT5zbGF2ZSA9IHNsYXZlUG9vbC52YWx1ZSggdHJhbnNw b3J0KCktPmlkKCkgKTsKKyAgZC0+c2xhdmUgPSBzX3NsYXZlUG9vbC0+c2xhdmVzLnZhbHVl KCB0cmFuc3BvcnQoKS0+aWQoKSApOwogICBpZiAoICFkLT5zbGF2ZSApIHsKICAgICBrRGVi dWcoKSA8PCAiY3JlYXRpbmcgbmV3IFNNVFAgc2xhdmUiOwogICAgIEtJTzo6TWV0YURhdGEg c2xhdmVDb25maWc7CkBAIC0xODUsNyArMjAxLDcgQEANCiAgICAgICBzbGF2ZUNvbmZpZy5p bnNlcnQoIFFMYXRpbjFTdHJpbmcoICJzYXNsIiApLCB0cmFuc3BvcnQoKS0+YXV0aGVudGlj YXRpb25UeXBlU3RyaW5nKCkgKTsKICAgICB9CiAgICAgZC0+c2xhdmUgPSBLSU86OlNjaGVk dWxlcjo6Z2V0Q29ubmVjdGVkU2xhdmUoIGRlc3RpbmF0aW9uLCBzbGF2ZUNvbmZpZyApOwot ICAgIHNsYXZlUG9vbC5pbnNlcnQoIHRyYW5zcG9ydCgpLT5pZCgpLCBkLT5zbGF2ZSApOwor ICAgIHNfc2xhdmVQb29sLT5zbGF2ZXMuaW5zZXJ0KCB0cmFuc3BvcnQoKS0+aWQoKSwgZC0+ c2xhdmUgKTsKICAgfSBlbHNlIHsKICAgICBrRGVidWcoKSA8PCAicmUtdXNpbmcgZXhpc3Rp bmcgc2xhdmUiOwogICB9CkBAIC0yMTAsNiArMjI2LDkgQEANCiAKIGJvb2wgU210cEpvYjo6 ZG9LaWxsKCkKIHsKKyAgaWYgKCBzX3NsYXZlUG9vbC5pc0Rlc3Ryb3llZCgpICkKKyAgICBy ZXR1cm4gZmFsc2U7CisKICAgaWYgKCAhaGFzU3Viam9icygpICkgewogICAgIHJldHVybiB0 cnVlOwogICB9CkBAIC0yMTksNyArMjM4LDcgQEANCiAgICAgS0lPOjpTaW1wbGVKb2IgKmpv YiA9IHN0YXRpY19jYXN0PEtJTzo6U2ltcGxlSm9iKj4oIHN1YmpvYnMoKS5maXJzdCgpICk7 CiAgICAgY2xlYXJTdWJqb2JzKCk7CiAgICAgS0lPOjpTY2hlZHVsZXI6OmNhbmNlbEpvYigg am9iICk7Ci0gICAgcmVtb3ZlU2xhdmVGcm9tUG9vbCggZC0+c2xhdmUgKTsKKyAgICBzX3Ns YXZlUG9vbC0+cmVtb3ZlU2xhdmUoIGQtPnNsYXZlICk7CiAgICAgcmV0dXJuIHRydWU7CiAg IH0KICAgcmV0dXJuIGZhbHNlOwpAQCAtMjI3LDYgKzI0Niw5IEBADQogCiB2b2lkIFNtdHBK b2I6OnNsb3RSZXN1bHQoIEtKb2IgKmpvYiApCiB7CisgIGlmICggc19zbGF2ZVBvb2wuaXNE ZXN0cm95ZWQoKSApCisgICAgcmV0dXJuOworCiAgIC8vIFRoZSBqb2IgaGFzIGZpbmlzaGVk LCBzbyB3ZSBkb24ndCBjYXJlIGFib3V0IGFueSBmdXJ0aGVyIGVycm9ycy4gU2V0CiAgIC8v IGQtPmZpbmlzaGVkIHRvIHRydWUsIHNvIHNsYXZlRXJyb3IoKSBrbm93cyBhYm91dCB0aGlz IGFuZCBkb2Vzbid0IGNhbGwKICAgLy8gZW1pdFJlc3VsdCgpIGFueW1vcmUuCkBAIC0yNDIs NyArMjY0LDcgQEANCiAKICAgVHJhbnNwb3J0Sm9iOjpzbG90UmVzdWx0KCBqb2IgKTsKICAg aWYgKCBlcnJvcigpICYmIGQtPmN1cnJlbnRTdGF0ZSA9PSBTbXRwSm9iUHJpdmF0ZTo6U210 cCApIHsKLSAgICByZW1vdmVTbGF2ZUZyb21Qb29sKCBkLT5zbGF2ZSwgZXJyb3IoKSAhPSBL SU86OkVSUl9TTEFWRV9ESUVEICk7CisgICAgc19zbGF2ZVBvb2wtPnJlbW92ZVNsYXZlKCBk LT5zbGF2ZSwgZXJyb3IoKSAhPSBLSU86OkVSUl9TTEFWRV9ESUVEICk7CiAgICAgcmV0dXJu OwogICB9CiAgIGlmICggIWVycm9yKCkgJiYgZC0+Y3VycmVudFN0YXRlID09IFNtdHBKb2JQ cml2YXRlOjpQcmVjb21tYW5kICkgewpAQCAtMjU3LDYgKzI3OSw5IEBADQogCiB2b2lkIFNt dHBKb2I6OmRhdGFSZXF1ZXN0KCBLSU86OkpvYiAqam9iLCBRQnl0ZUFycmF5ICZkYXRhICkK IHsKKyAgaWYgKCBzX3NsYXZlUG9vbC5pc0Rlc3Ryb3llZCgpICkKKyAgICByZXR1cm47CisK ICAgUV9BU1NFUlQoIGpvYiApOwogICBpZiAoIGJ1ZmZlcigpLT5hdEVuZCgpICkgewogICAg IGRhdGEuY2xlYXIoKTsKQEAgLTI2OSw3ICsyOTQsMTAgQEANCiAKIHZvaWQgU210cEpvYjo6 c2xhdmVFcnJvciggS0lPOjpTbGF2ZSAqc2xhdmUsIGludCBlcnJvckNvZGUsIGNvbnN0IFFT dHJpbmcgJmVycm9yTXNnICkKIHsKLSAgcmVtb3ZlU2xhdmVGcm9tUG9vbCggc2xhdmUsIGVy cm9yQ29kZSAhPSBLSU86OkVSUl9TTEFWRV9ESUVEICk7CisgIGlmICggc19zbGF2ZVBvb2wu aXNEZXN0cm95ZWQoKSApCisgICAgcmV0dXJuOworCisgIHNfc2xhdmVQb29sLT5yZW1vdmVT bGF2ZSggc2xhdmUsIGVycm9yQ29kZSAhPSBLSU86OkVSUl9TTEFWRV9ESUVEICk7CiAgIGlm ICggZC0+c2xhdmUgPT0gc2xhdmUgJiYgIWQtPmZpbmlzaGVkICkgewogICAgIHNldEVycm9y KCBlcnJvckNvZGUgKTsKICAgICBzZXRFcnJvclRleHQoIEtJTzo6YnVpbGRFcnJvclN0cmlu ZyggZXJyb3JDb2RlLCBlcnJvck1zZyApICk7Cg== --------------080901050104010005090903 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ KDE PIM mailing list kde-pim@kde.org https://mail.kde.org/mailman/listinfo/kde-pim KDE PIM home page at http://pim.kde.org/ --------------080901050104010005090903--