[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] [patch] KMail: avoid one warning and one crash
From:       Thomas McGuire <thomas.mcguire () gmx ! net>
Date:       2008-05-20 20:27:35
Message-ID: 200805202227.35975.thomas.mcguire () gmx ! net
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


Hi,

On Tuesday 20 May 2008, Jarosław Staniek wrote:
> Two changes for review:
> 1. KMailICalIfaceImpl::findMessageBySerNum(): avid warnings when serNum ==
> 0: return immediately as we do not expect to have 0 serial nums.
>
> 2. KMAcctCachedImap::killAllJobsInternal(): check mSlave before accessing
> it.key() - this could avoid crash when KJob is already dead.
Seems fine to me.

Regards,
Thomas



["signature.asc" (application/pgp-signature)]

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

[prev in list] [next in list] [prev in thread] [next in thread]