From kde-pim  Tue May 20 10:21:41 2008
From: =?UTF-8?B?SmFyb3PFgmF3IFN0YW5pZWs=?= <js () iidea ! pl>
Date: Tue, 20 May 2008 10:21:41 +0000
To: kde-pim
Subject: [Kde-pim] [patch] KMail: avoid one warning and one crash
Message-Id: <4832A635.8010109 () iidea ! pl>
X-MARC-Message: https://marc.info/?l=kde-pim&m=121127893627169
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--------------050401070905020706010802"

This is a multi-part message in MIME format.
--------------050401070905020706010802
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


Two changes for review:
1. KMailICalIfaceImpl::findMessageBySerNum(): avid warnings when serNum == 0: 
return immediately as we do not expect to have 0 serial nums.

2. KMAcctCachedImap::killAllJobsInternal(): check mSlave before accessing 
it.key() - this could avoid crash when KJob is already dead.

-- 
regards / pozdrawiam, Jaroslaw Staniek
  Sponsored by OpenOffice Polska (http://www.openoffice.com.pl/en) to work on
  Kexi & KOffice (http://www.kexi.pl/en, http://www.koffice.org/kexi)
  KDE Libraries for MS Windows (http://windows.kde.org)

--------------050401070905020706010802
Content-Type: text/plain;
 name="kmail.patch"
Content-Transfer-Encoding: base64
Content-Disposition: inline;
 filename="kmail.patch"

SW5kZXg6IGttYWlsaWNhbGlmYWNlaW1wbC5jcHANCj09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBrbWFp
bGljYWxpZmFjZWltcGwuY3BwCSh3ZXJzamEgODA5NjIxKQ0KKysrIGttYWlsaWNhbGlmYWNl
aW1wbC5jcHAJKGtvcGlhIHJvYm9jemEpDQpAQCAtMTI5Niw3ICsxMjk2LDcgQEANCiAvLyBG
aW5kIG1lc3NhZ2UgbWF0Y2hpbmcgYSBnaXZlbiBzZXJpYWwgbnVtYmVyCiBLTU1lc3NhZ2Ug
KktNYWlsSUNhbElmYWNlSW1wbDo6ZmluZE1lc3NhZ2VCeVNlck51bSggcXVpbnQzMiBzZXJO
dW0sIEtNRm9sZGVyKiBmb2xkZXIgKQogewotICBpZiggIWZvbGRlciApIHJldHVybiAwOwor
ICBpZiggIWZvbGRlciB8fCBzZXJOdW0gPT0gMCApIHJldHVybiAwOwogCiAgIEtNTWVzc2Fn
ZSAqbWVzc2FnZSA9IDA7CiAgIEtNRm9sZGVyKiBhRm9sZGVyID0gMDsKSW5kZXg6IGttYWNj
dGNhY2hlZGltYXAuY3BwDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0ga21hY2N0Y2FjaGVkaW1hcC5j
cHAJKHdlcnNqYSA4MDk2MjEpDQorKysga21hY2N0Y2FjaGVkaW1hcC5jcHAJKGtvcGlhIHJv
Ym9jemEpDQpAQCAtMTI3LDcgKzEyNyw3IEBADQogICAgIGlmICgoKml0KS5wYXJlbnQpCiAg
ICAgICBmb2xkZXJMaXN0IDw8IHN0YXRpY19jYXN0PEtNRm9sZGVyQ2FjaGVkSW1hcCo+KCgq
aXQpLnBhcmVudC0+c3RvcmFnZSgpKTsKICAgICAvLyBLaWxsIHRoZSBqb2IgLSBleGNlcHQg
aWYgaXQncyB0aGUgb25lIHRoYXQgYWxyZWFkeSBkaWVkIGFuZCBpcyBjYWxsaW5nIHVzCi0g
ICAgaWYgKCAhaXQua2V5KCktPmVycm9yKCkgJiYgbVNsYXZlICkgeworICAgIGlmICggbVNs
YXZlICYmICFpdC5rZXkoKS0+ZXJyb3IoKSApIHsKICAgICAgIGl0LmtleSgpLT5raWxsKCk7
CiAgICAgICBtU2xhdmUgPSAwOyAvLyBraWxsaW5nIGEgam9iLCBraWxscyB0aGUgc2xhdmUK
ICAgICB9Cg==
--------------050401070905020706010802
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
--------------050401070905020706010802--