--===============1500829258==
Content-Type: multipart/signed;
  boundary="nextPart2066963.rrallogjZH";
  protocol="application/pgp-signature";
  micalg=pgp-sha1
Content-Transfer-Encoding: 7bit

--nextPart2066963.rrallogjZH
Content-Type: multipart/mixed;
  boundary="Boundary-01=_wGLIIsXljMCXpx/"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

--Boundary-01=_wGLIIsXljMCXpx/
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

(please reply to all, I'm not subscribed)

Hi!

At the Debian groupware meeting last month, Wilfried from citadel.org=20
mentioned to me the fact, that Citadel would work well as a Kolab1 server f=
or=20
Kontact, if it wasn't for messed up ACL-lists in KMail when userids with=20
spaces in them are involved. Attached is a patch for KDEPIM3.5.9 to fix tha=
t.

Whoever wrote the ACL-Code in kio_imap4, wrote in his code-comment, that he=
=20
thought spaces weren't allowed in userids and so he used it as a seperator.=
=20
It seems to me though, that Citadel is right to allow spaces in userids,=20
because I can't find anything against that in rfc3501.txt.

The RFC states double-quotes are a forbidden character though, so I used it=
 in=20
my patch instead.

I'm not sure to commit though, because I don't know if any app besides KMai=
l=20
uses kio_imap4 and I don't want to break any such program. What do you thin=
k?=20
Is it safe to commit?

Greetings,
Carsten
=2D-=20
           /\-=C2=B4-/\
          (  @ @  )
________o0O___^___O0o________=09

--Boundary-01=_wGLIIsXljMCXpx/
Content-Type: text/x-diff;
  charset="utf-8";
  name="imap_acl_handle_userid_with_blank.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename="imap_acl_handle_userid_with_blank.diff"

diff -ur kdepim-3.5.9.orig/kioslaves/imap4/imap4.cc kdepim-3.5.9/kioslaves/imap4/imap4.cc
--- kdepim-3.5.9.orig/kioslaves/imap4/imap4.cc	2008-02-13 10:39:38.000000000 +0100
+++ kdepim-3.5.9/kioslaves/imap4/imap4.cc	2008-05-06 20:34:41.000000000 +0200
@@ -1496,7 +1496,7 @@
     // limits me to a string instead of a stringlist. I'm using space as separator,
     // since I don't think it can be used in login names.
     kdDebug(7116) << getResults() << endl;
-    infoMessage(getResults().join( " " ));
+    infoMessage(getResults().join( "\"" ));
     finished();
     break;
   }
diff -ur kdepim-3.5.9.orig/kmail/acljobs.cpp kdepim-3.5.9/kmail/acljobs.cpp
--- kdepim-3.5.9.orig/kmail/acljobs.cpp	2007-10-08 11:50:38.000000000 +0200
+++ kdepim-3.5.9/kmail/acljobs.cpp	2008-05-06 20:32:44.000000000 +0200
@@ -175,7 +175,7 @@
 void ACLJobs::GetACLJob::slotInfoMessage( KIO::Job*, const QString& str )
 {
   // Parse the result
-  QStringList lst = QStringList::split( " ", str, true );
+  QStringList lst = QStringList::split( "\"", str, true );
   while ( lst.count() >= 2 ) // we take items 2 by 2
   {
     QString user = lst.front(); lst.pop_front();

--Boundary-01=_wGLIIsXljMCXpx/--

--nextPart2066963.rrallogjZH
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQBIILG28elb1gg1f/QRAvIeAKCfXBAC53waMJ5iipaxgMc8Wq63fQCfdtG9
Fgd8x0PfPp8wrfEsap1L4YI=
=mpW/
-----END PGP SIGNATURE-----

--nextPart2066963.rrallogjZH--

--===============1500829258==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
--===============1500829258==--